It was <2014-01-07 wto 03:28>, when MyungJoo Ham wrote: > ------- Original Message ------- > Sender : Dong, Junfeng<[email protected]> > Date : 2014-01-06 19:22 (GMT+09:00) >> Hi Gerrit administer, >> When uploading new patch set, the review result for the former >> changes isn’t cleaned. This seems unreasonable. Could you please fix >> this? https://review.tizen.org/gerrit/#/c/13909/ > > From the gerrit documentation: > (https://review.tizen.org/gerrit/Documentation/config-labels.html) > > " > > * -2 Do not submit > > The code is so horribly incorrect/buggy/broken that it must not be > submitted to this project, or to this branch. This value is valid > across all patch sets in the same change, i.e. the reviewer must > actively change his/her review to something else before the change > is submittable. > > Any -2 blocks submit. > > " > > You need to discuss it with Lukasz and show him that the change > addressed the mentioned issue correctly.
I am sorry it took a bit longer, yesterday it was a holiday in Poland and I didn't touch gerrit. I havn't forgotten about the change and it has already got mine +2. Great job, thanks. -- Łukasz Stelmach Samsung R&D Institute Poland Samsung Electronics
pgpeHNXvcAi_p.pgp
Description: PGP signature
_______________________________________________ Dev mailing list [email protected] https://lists.tizen.org/listinfo/dev
