On quinta-feira, 30 de janeiro de 2014 21:54:20, Patrick Ohly wrote: > On Thu, 2014-01-30 at 10:48 -0800, Thiago Macieira wrote: > > Ensuring that everything got reviewed is the responsibility of the > > maintainer. But it's the *interest* of the contributor, so the > > contributor should pay attention to the state of the contribution. > > > > If a contribution goes unreviewed after a while, ping the reviewers. > > That's impractical when the list of reviewers is larger than a handful. > Who should get contacted? Randomly? Chances are high that the ones not > doing any active work on the package will get pinged, annoying them > further and causing additional delays.
Just write a new comment saying "ping". Any of the reviewers is capable of approving the change. The question is only whether they feel confident in doing so. > What's your take on those packages which currently have more than ten > reviewers? Having that many reviewers is great! That means more people to look at the changes, to find potential issues, offer advice as well as to provide round-the- clock ability to review things. Having too few reviewers (or none) is a bad thing -- for example, for my changes in QtCore, very often no one can review them, which means I need to seek exceptions. The problem we have in Tizen is not that we have too few reviewers. It's that each reviewer says "there are others, they'll review" and no one ends up doing it. I would have preferred that the Cc list for each contribution have no more than 10 people. More than that, we've got the effect I mentioned. Also, reviewers are encouraged to keep their Gerrit Dashboard *clean*. Review everything that you can review or remove yourself from the Cc list of a change that you don't feel competent to review[*]. [*] Except if you're the maintainer, then you have to ensure it gets reviewed by you or someone else. > > If it > > still doesn't get reviewed, ping the maintainer (write "maintainer ping", > > for example). Sometimes the maintainer will not notice that it's the same > > contribution that no one else reviewed. > > In Tizen 3.0, we have 1276 packages (= packages with a "tizen" branch). > Of those, 655 have no dedicated maintainer. What should be done about > those? A maintainer needs to be found. Any interested and capable reviewer can volunteer to become the maintainer. Failing that, any competent developer. At the very least, we need a gatekeeper that can approve maintenance tasks. If no maintainer is found, we should conclude that the package is abandoned and should be dropped from Tizen. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Dev mailing list [email protected] https://lists.tizen.org/listinfo/dev
