> -----Original Message----- > From: Łukasz Stelmach [mailto:[email protected]] > Sent: Monday, February 03, 2014 4:45 AM > To: Schaufler, Casey > Cc: Hanchett, Paul; Philippe Coval; [email protected] > Subject: Re: [Dev] State of Pending changes , how to enhance workflow ? ( > Was Dear Maintainers ) > > It was <2014-01-31 pią 19:39>, when Schaufler, Casey wrote: > > Another alternative is that we require a Reviewed-by: line just like > > we require a Signed-off-by: and a Change-id: when a change is > > submitted. The dedicated reviewers could decide if that was good > > enough and would have some assurance that the change had been run > past > > someone. Of course, “Reviewed-by:” can’t be the submitter. > > This is technically impossible and pointless with Gerrit. +1s and +2s > (ticks) do mean exactly the same as Reviewed-by without creating a new > commit (that is required to change commit message).
I'm sorry, I wasn't clear. Before the submit to gerrit the developer gets the code reviewed. The initial submit to gerrit includes the "Reviewed-by:" line. What I'm trying to say here is that the review is done first, then the submit. That way you don't get hung up waiting for a review. The problem we are seeing is that reviews are not getting done. Put the burden of getting a review on the developer. > > -- > Łukasz Stelmach > Samsung R&D Institute Poland > Samsung Electronics _______________________________________________ Dev mailing list [email protected] https://lists.tizen.org/listinfo/dev
