+1
- ASC, MD5 and SHA1 are OK on src zip.
- Building it worked for me from the src zip with 'mvn clean install site'.
- RAT check OK.
- I did not try to use build products from Scala.
Using:
Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
2017-04-03T12:39:06-07:00)
Maven home: C:\Java\apache-maven-3.5.0\bin\..
Java version: 1.8.0_141, vendor: Oracle Corporation
Java home: C:\Program Files\Java\jdk1.8.0_141\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
I noticed WARNINGs like:
[INFO] --- scala-maven-plugin:3.2.2:compile (default) @
log4j-api-scala_2.11 ---
[WARNING] Expected all dependencies to require Scala version: 2.11.8
[WARNING] org.apache.logging.log4j:log4j-api-scala_2.11:11.0 requires
scala version: 2.11.8
[WARNING] org.scala-lang:scala-reflect:2.11.8 requires scala version:
2.11.8
[WARNING] org.scalatest:scalatest_2.11:3.0.0 requires scala version: 2.11.8
[WARNING] org.scalactic:scalactic_2.11:3.0.0 requires scala version: 2.11.8
[WARNING] org.scala-lang.modules:scala-xml_2.11:1.0.5 requires scala
version: 2.11.7
[WARNING] Multiple versions of scala libraries detected!
and:
[INFO] <<< scala-maven-plugin:3.2.2:doc < generate-sources @
log4j-api-scala_2.10 <<<
[INFO]
[INFO] 'generate-sources' forked phase execution for scala-maven-plugin:doc
report preparation done
[INFO] configuring report plugin
org.apache.maven.plugins:maven-project-info-reports-plugin:2.9
[WARNING] Unable to locate Source XRef to link to - DISABLED
[WARNING] Unable to locate Source XRef to link to - DISABLED
and:
C:\temp\rc\apache-log4j-scala-11.0-src\log4j-api-scala_2.11\src\main\scala\org\apache\logging\log4j\scala\Logger.scala:59:
warning: Variable user.getName undefined in comment for class Logger in
class Logger
* logger.debug(s"Logging in user ${user.getName} with birthday
${user.calcBirthday}")
^
C:\temp\rc\apache-log4j-scala-11.0-src\log4j-api-scala_2.11\src\main\scala\org\apache\logging\log4j\scala\Logger.scala:59:
warning: Variable user.calcBirthday undefined in comment for class Logger
in class Logger
* logger.debug(s"Logging in user ${user.getName} with birthday
${user.calcBirthday}")
^
two warnings found
Using:
Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
2017-04-03T12:39:06-07:00)
Maven home: C:\Java\apache-maven-3.5.0\bin\..
Java version: 1.8.0, vendor: IBM Corporation
Java home: C:\eclipse\IBM-6.4.5\ibm_sdk80\jre
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "x86", family: "windows"
I noticed:
C:\temp\rc\apache-log4j-scala-11.0-src\log4j-api-scala_2.10\src\main\scala\org\apache\logging\log4j\scala\Logger.scala:65:
warning: Variable user.getName undefined in comment for class Logger in
class Logger
class Logger private(val delegate: ExtendedLogger) extends AnyVal {
^
one warning found
The build goes on and eventually crashes the IBM JVM:
[INFO] --- scala-maven-plugin:3.2.2:compile (default) @
log4j-api-scala_2.12 ---
[WARNING] Expected all dependencies to require Scala version: 2.12.1
[WARNING] org.apache.logging.log4j:log4j-api-scala_2.12:11.0 requires
scala version: 2.12.1
[WARNING] org.scala-lang:scala-reflect:2.12.1 requires scala version:
2.12.1
[WARNING] org.scalatest:scalatest_2.12:3.0.0 requires scala version: 2.12.0
[WARNING] Multiple versions of scala libraries detected!
[INFO]
C:\temp\rc\apache-log4j-scala-11.0-src\log4j-api-scala_2.12\src\main\scala:-1:
info: compiling
[INFO] Compiling 4 source files to
C:\temp\rc\apache-log4j-scala-11.0-src\log4j-api-scala_2.12\target\classes
at 1500513231804
[INFO] Unhandled exception
[ERROR] Type=Segmentation error vmState=0x000507ff
[INFO] J9Generic_Signal_Number=00000004 ExceptionCode=c0000005
ExceptionAddress=031C6387 ContextFlags=0001007f
[INFO] Handler1=7E6E7D50 Handler2=7E9C1C70 InaccessibleReadAddress=00000004
[INFO] EDI=25E2CBB8 ESI=25E2CBC4 EAX=25DC65C8 EBX=25DCA344
[INFO] ECX=25DC6210 EDX=00000000
[INFO] EIP=031C6387 ESP=24FAEB08 EBP=25DDA538 EFLAGS=00010246
[INFO] GS=002B FS=0053 ES=002B DS=002B
[INFO] Module=C:\eclipse\IBM-6.4.5\ibm_sdk80\jre\bin\default\j9jit28.dll
[INFO] Module_base_address=02FB0000 Offset_in_DLL=00216387
[INFO]
[INFO] Method_being_compiled=scala/collection/mutable/HashMap.index(I)I
[INFO] Target=2_80_20170419_344392 (Windows 10 10.0 build 15063)
[INFO] CPU=x86 (4 logical CPUs) (0x3da7aa000 RAM)
[INFO] ----------- Stack Backtrace -----------
[INFO] Unhandled exception
[ERROR] Type=Segmentation error vmState=0x000507ff
[INFO] J9Generic_Signal_Number=00000004 ExceptionCode=c0000005
ExceptionAddress=031C6387 ContextFlags=0001007f
[INFO] Handler1=7E6E7D50 Handler2=7E9C1C70 InaccessibleReadAddress=00000004
[INFO] EDI=260ECBD0 ESI=260ECBDC EAX=260865E0 EBX=2608A35C
[INFO] ECX=26086228 EDX=00000000
[INFO] EIP=031C6387 ESP=24E6EE70 EBP=2609A550 EFLAGS=00010246
[INFO] GS=002B FS=0053 ES=002B DS=002B
[INFO] Module=C:\eclipse\IBM-6.4.5\ibm_sdk80\jre\bin\default\j9jit28.dll
[INFO] Module_base_address=02FB0000 Offset_in_DLL=00216387
[INFO]
[INFO]
Method_being_compiled=scala/collection/mutable/HashMap.elemHashCode(Ljava/lang/Object;)I
[INFO] Target=2_80_20170419_344392 (Windows 10 10.0 build 15063)
[INFO] CPU=x86 (4 logical CPUs) (0x3da7aa000 RAM)
[INFO] ----------- Stack Backtrace -----------
[INFO] Unhandled exception
[ERROR] Type=Segmentation error vmState=0x000507ff
[INFO] J9Generic_Signal_Number=00000004 ExceptionCode=c0000005
ExceptionAddress=031C6387 ContextFlags=0001007f
[INFO] Handler1=7E6E7D50 Handler2=7E9C1C70 InaccessibleReadAddress=00000004
[INFO] EDI=2818D078 ESI=2818D084 EAX=28126C9C EBX=2813A830
[INFO] ECX=2812683C EDX=00000000
[INFO] EIP=031C6387 ESP=250EED04 EBP=2813AA24 EFLAGS=00010246
[INFO] GS=002B FS=0053 ES=002B DS=002B
[INFO] Module=C:\eclipse\IBM-6.4.5\ibm_sdk80\jre\bin\default\j9jit28.dll
[INFO] Module_base_address=02FB0000 Offset_in_DLL=00216387
[INFO]
[INFO] Method_being_compiled=scala/collection/mutable/HashTable.index(I)I
[INFO] Target=2_80_20170419_344392 (Windows 10 10.0 build 15063)
[INFO] CPU=x86 (4 logical CPUs) (0x3da7aa000 RAM)
[INFO] ----------- Stack Backtrace -----------
[INFO] Unhandled exception
[ERROR] Type=Segmentation error vmState=0x00040000
[INFO] J9Generic_Signal_Number=00000004 ExceptionCode=c0000005
ExceptionAddress=27170EF9 ContextFlags=0001007f
[INFO] Handler1=7E6E7D50 Handler2=7E9C1C70 InaccessibleReadAddress=701DE706
[INFO] EDI=00000000 ESI=24836C41 EAX=00000000 EBX=27170E7E
[INFO] ECX=00000001 EDX=25847EF0
[INFO] EIP=27170EF9 ESP=25847EF8 EBP=24836C40 EFLAGS=00010246
[INFO] GS=002B FS=0053 ES=002B DS=002B
[INFO] Module=
[INFO] Module_base_address=27170000 Offset_in_DLL=00000ef9
[INFO]
[INFO]
Compiled_method=scala/collection/mutable/HashTable.findEntry(Ljava/lang/Object;)Lscala/collection/mutable/HashEntry;
[INFO] Target=2_80_20170419_344392 (Windows 10 10.0 build 15063)
[INFO] CPU=x86 (4 logical CPUs) (0x3da7aa000 RAM)
[INFO] ----------- Stack Backtrace -----------
Gary
On Wed, Jul 19, 2017 at 5:48 PM, Matt Sicker <[email protected]> wrote:
> So we're reaching the same state as the first release candidate: 1 cast
> vote, 1 implicit vote (I'll wait), and still no 3rd vote. Can I get another
> vote?
>
> On 17 July 2017 at 10:13, Matt Sicker <[email protected]> wrote:
>
> > Agreed. I've been using 11.0-SNAPSHOT in my projects at work for a while
> > now as it is.
> >
> > On 17 July 2017 at 07:39, Mikael Ståldal <[email protected]> wrote:
> >
> >> Changing the artifactId would be annoying for the users who are already
> >> using this (the Scala API has already been publicly released quite some
> >> time ago through the main repo). I don't like that.
> >>
> >>
> >> On 2017-07-16 23:04, Ralph Goers wrote:
> >>
> >>> To address Gary’s issues I think it would be better to use a different
> >>> module name and start from version 1.0.
> >>>
> >>> Ralph
> >>>
> >>> On Jul 16, 2017, at 1:43 PM, Gary Gregory <[email protected]>
> >>>> wrote:
> >>>>
> >>>> I know... :-(
> >>>>
> >>>> The checksums are generated either by some Maven plugin or Nexus.
> >>>>
> >>>> Gary
> >>>>
> >>>> On Sun, Jul 16, 2017 at 1:38 PM, Mikael Ståldal <[email protected]>
> >>>> wrote:
> >>>>
> >>>> The md5sum and sha1sum tools are able to do the comparations themself
> if
> >>>>> the checksum file contains the filename, which those checksum files
> >>>>> doesn't. Why not?
> >>>>>
> >>>>> We need to automate this, it's tedious and error-prone to do all this
> >>>>> checksum verification manually.
> >>>>>
> >>>>>
> >>>>>
> >>>>> On 2017-07-16 22:29, Gary Gregory wrote:
> >>>>>
> >>>>> On Sun, Jul 16, 2017 at 1:27 PM, Mikael Ståldal <[email protected]>
> >>>>>> wrote:
> >>>>>>
> >>>>>> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> >>>>>>
> >>>>>>> 2015-11-10T17:41:47+01:00)
> >>>>>>> Maven home: /opt/apache-maven-3.3.9
> >>>>>>> Java version: 1.8.0_131, vendor: Oracle Corporation
> >>>>>>> Java home: /opt/jvm/jdk1.8.0_131/jre
> >>>>>>> Default locale: en_US, platform encoding: UTF-8
> >>>>>>> OS name: "linux", version: "4.4.0-83-generic", arch: "amd64",
> family:
> >>>>>>> "unix"
> >>>>>>>
> >>>>>>> I did all three actions mentions in the BUINGING.md:
> >>>>>>> mvn apache-rat:check
> >>>>>>> mvn clean install
> >>>>>>> mvn site
> >>>>>>>
> >>>>>>> on both master and the 11.0-rc2 tag in Git.
> >>>>>>>
> >>>>>>> I also tried the artifacts published to the staging repository
> with a
> >>>>>>> test
> >>>>>>> project of mine.
> >>>>>>>
> >>>>>>> Not sure how I am supposed to check the ASC, MD5 and SHA1 files in
> a
> >>>>>>> convenient way.
> >>>>>>>
> >>>>>>>
> >>>>>>> On Cygwin/Linux:
> >>>>>>
> >>>>>> md5sum <FILENAME>
> >>>>>> and compare the to contents of the .md5 file
> >>>>>>
> >>>>>> sha1sum <FILENAME>
> >>>>>> and compare the to contents of the .sha1 file
> >>>>>>
> >>>>>> Then:
> >>>>>>
> >>>>>> gpg --verify <ASC_FILE> <ZIP_FILE>
> >>>>>>
> >>>>>> and eyeball the output.
> >>>>>>
> >>>>>> Gary
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>> Do we have a checklist of what we are supposed to do?
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>> On 2017-07-16 21:50, Gary Gregory wrote:
> >>>>>>>
> >>>>>>> As a PMC, we think we need to better document our "+1"s than
> >>>>>>> "Everything
> >>>>>>>
> >>>>>>>> seems fine."
> >>>>>>>>
> >>>>>>>> For example: Did you check the ASC, MD5 and SHA1 files?
> >>>>>>>>
> >>>>>>>> _How_ exactly does it "seem" fine?
> >>>>>>>>
> >>>>>>>> What JDK(s) did you use to build? What did you build? From what?
> The
> >>>>>>>> tag?
> >>>>>>>> The zip?
> >>>>>>>>
> >>>>>>>> And so on.
> >>>>>>>>
> >>>>>>>> Gary
> >>>>>>>>
> >>>>>>>> On Sun, Jul 16, 2017 at 12:04 PM, Mikael Ståldal <
> [email protected]>
> >>>>>>>> wrote:
> >>>>>>>>
> >>>>>>>> +1
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>> Everything seems fine.
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>> On 2017-07-16 18:41, Matt Sicker wrote:
> >>>>>>>>>
> >>>>>>>>> Hello all, sorry for the delay between release candidates. This
> is
> >>>>>>>>> a
> >>>>>>>>> vote
> >>>>>>>>>
> >>>>>>>>> to release RC2 of Log4j Scala API 11.0, the first release of the
> >>>>>>>>>> new
> >>>>>>>>>> repository. The main features in this release are Scala 2.12
> >>>>>>>>>> support
> >>>>>>>>>> and
> >>>>>>>>>> an
> >>>>>>>>>> API for manipulating the ThreadContext.
> >>>>>>>>>>
> >>>>>>>>>> Artifacts are available in this staging repository: <
> >>>>>>>>>> https://repository.apache.org/content/repositories/orgapache
> >>>>>>>>>> logging-1028/
> >>>>>>>>>>
> >>>>>>>>>> .
> >>>>>>>>>>
> >>>>>>>>>>>
> >>>>>>>>>>> The site is on <https://rgoers.github.io/log4j-scala-site/>
> >>>>>>>>>>> (though
> >>>>>>>>>>>
> >>>>>>>>>> it's
> >>>>>>>>>> not appearing for me at the time of writing). Don't mind the
> >>>>>>>>>> styling
> >>>>>>>>>> issues
> >>>>>>>>>> in component pages as these will point to the correct paths when
> >>>>>>>>>> merged
> >>>>>>>>>> with the existing site.
> >>>>>>>>>>
> >>>>>>>>>> The artifacts are signed with my GPG key with the
> >>>>>>>>>> ID 748F15B2CF9BA8F024155E6ED7C92B70FA1C814D which is available
> >>>>>>>>>> in the
> >>>>>>>>>> Logging KEYS file.
> >>>>>>>>>>
> >>>>>>>>>> Artifacts can be downloaded using the following command:
> >>>>>>>>>>
> >>>>>>>>>> wget -e robots=off --cut-dirs=7 -nH -r -p -np
> >>>>>>>>>> --no-check-certificate
> >>>>>>>>>> https://repository.apache.org/content/repositories/orgapache
> >>>>>>>>>> logging-1028/org/apache/logging/log4j/
> >>>>>>>>>>
> >>>>>>>>>> If that doesn't work, please let me know so I can note the
> correct
> >>>>>>>>>> command
> >>>>>>>>>> for future vote emails.
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>
> >>>>>>>>
> >>>>>>>
> >>>>>>
> >>>>>
> >>>
> >>>
> >>
> >
> >
> > --
> > Matt Sicker <[email protected]>
> >
>
>
>
> --
> Matt Sicker <[email protected]>
>
