Github user dpsenner commented on a diff in the pull request:
https://github.com/apache/logging-log4net/pull/14#discussion_r133704161
--- Diff: tests/src/log4net.Tests.csproj ---
@@ -19,245 +18,25 @@
under the License.
-->
-<Project DefaultTargets="Build"
xmlns="http://schemas.microsoft.com/developer/msbuild/2003"; ToolsVersion="4.0">
+<Project Sdk="Microsoft.NET.Sdk">
+
<PropertyGroup>
- <ProjectType>Local</ProjectType>
- <ProductVersion>9.0.30729</ProductVersion>
- <SchemaVersion>2.0</SchemaVersion>
- <ProjectGuid>{B0530F10-0238-49A9-93B0-8EF412E90BCF}</ProjectGuid>
- <Configuration Condition=" '$(Configuration)' == ''
">Debug</Configuration>
- <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
- <ApplicationIcon>
- </ApplicationIcon>
- <AssemblyKeyContainerName>
- </AssemblyKeyContainerName>
+ <!--
+ Currently multitargeting tests doesn't work, separate projects
are required.
+ (tracked at https://github.com/Microsoft/vstest/issues/298 and
https://github.com/Microsoft/vstest/issues/624)
+ -->
+ <TargetFramework>netcoreapp2.0</TargetFramework>
--- End diff --
If this is the case, should we add multiple test projects targeting
different frameworks?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
