Github user chlowell commented on a diff in the pull request:

    https://github.com/apache/logging-log4net/pull/14#discussion_r133846257
  
    --- Diff: src/Appender/AppenderSkeleton.cs ---
    @@ -321,7 +321,7 @@ public void DoAppend(LoggingEvent loggingEvent)
                                {
                                        ErrorHandler.Error("Failed in 
DoAppend", ex);
                                }
    -#if !MONO && !NET_2_0 && !NETSTANDARD1_3
    +#if !(MONO || NET_2_0 || NETSTANDARD1_3 || NETSTANDARD2_0)
    --- End diff --
    
    I used the FrameworkMajor_Minor convention because it's used by the build 
system, e.g. `NETSTANDARD1_3` is defined when building a `netstandard1.3` 
library (more details in the Target Frameworks 
[doc](https://docs.microsoft.com/en-us/dotnet/standard/frameworks)).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to