As I said, no one with commit privs should appear in the due-to. Ever. They already appear in the by column and in git. It diminishes the thanks we give to contributors to add ourselves, so I would request you please stop doing that, frankly I am not sure why you started as I don’t recall seeing you do that until recently.
Ralph > On Aug 13, 2019, at 9:48 PM, Gary Gregory <garydgreg...@gmail.com> wrote: > > The convention I use is dev is the committer and due-to is the creator of > the Jira or PR followed by whomever else touched the code. > > Gary > >> On Tue, Aug 13, 2019, 20:13 Ralph Goers <ralph.go...@dslextreme.com> wrote: >> >> Gary, >> >> I am wondering why you have recently gotten in the habit of adding >> yourself to the due-to field of changes.xml. Historically we have always >> used that to give credit to non-committers who provide patches or >> significantly contribute to them. As committers we get credit in the >> source control and in the dev field of the action entry. It seems over the >> top to be giving ourselves credit that way and, in fact, takes away from >> the contributions we receive from non-committers as every single change is >> due to one of us, even if all we do is commit the patch. >> >> If we need to vote on this I would vote that committers names should never >> appear in the due-to field. >> >> Ralph >>
