Talph,

Feel free to edit changes.xml as you best see fit.

Gary

On Tue, Aug 13, 2019, 22:37 Ralph Goers <ralph.go...@dslextreme.com> wrote:

> The “By” column is a link to the team list that includes all your
> information. If you don’t use your userid then the link won’t index into
> the list properly.
>
> Frankly, putting my name in the due-to column would feel like I would be
> sending a self congratulatory public thank you note to myself. It is over
> the top.
>
> Ralph
>
> > On Aug 13, 2019, at 8:51 PM, Matt Sicker <boa...@gmail.com> wrote:
> >
> > Can the “By” column contain real names instead of usernames?
> >
> > On Tue, Aug 13, 2019 at 22:18, Ralph Goers <ralph.go...@dslextreme.com>
> > wrote:
> >
> >> I should also add that the changes report already gives credit to the
> >> committer - see the “By” column at
> >> http://logging.apache.org/log4j/2.x/changes-report.html#a2.12.1 <
> >> http://logging.apache.org/log4j/2.x/changes-report.html#a2.12.1> so by
> >> adding yourself to the due-to field you are giving yourself credit
> twice.
> >>
> >> Ralph
> >>
> >>> On Aug 13, 2019, at 8:13 PM, Ralph Goers <ralph.go...@dslextreme.com>
> >> wrote:
> >>>
> >>> Gary,
> >>>
> >>> I am wondering why you have recently gotten in the habit of adding
> >> yourself to the due-to field of changes.xml. Historically we have always
> >> used that to give credit to non-committers who provide patches or
> >> significantly contribute to them.  As committers we get credit in the
> >> source control and in the dev field of the action entry. It seems over
> the
> >> top to be giving ourselves credit that way and, in fact, takes away from
> >> the contributions we receive from non-committers as every single change
> is
> >> due to one of us, even if all we do is commit the patch.
> >>>
> >>> If we need to vote on this I would vote that committers names should
> >> never appear in the due-to field.
> >>>
> >>> Ralph
> >>>
> >>
> >> --
> > Matt Sicker <boa...@gmail.com>
>
>
>

Reply via email to