Given that there have been no other responses I am going to close this vote. I will create a new release candidate as soon as I can.
Ralph > On Dec 10, 2019, at 8:23 AM, Ralph Goers <[email protected]> wrote: > > I just noticed that Jenkins also has a unit test failing in log4j-1.2-api. > > Ralph > >> On Dec 10, 2019, at 8:06 AM, Carter Kozak <[email protected]> wrote: >> >> I'm planning to test and benchmark with several projects I'm responsible for >> today. >> >> On Tue, Dec 10, 2019, at 10:03, Ralph Goers wrote: >>> Thanks Gary, although it would have been nice to have had feedback on the >>> failing unit test in the 4 months since it has been in place instead of >>> waiting until after the release vote to test it. >>> >>> Are any other PMC members planning on voting on the release or do I need to >>> create another release candidate? >>> >>> Ralph >>> >>> >>>> On Dec 10, 2019, at 7:57 AM, Gary Gregory <[email protected]> wrote: >>>> >>>> I'm not OK with that kind of workaround, as a user it does not inspire >>>> confidence. I won't -1 though. >>>> >>>> Gary >>>> >>>> On Tue, Dec 10, 2019 at 12:21 AM Ralph Goers <[email protected]> >>>> wrote: >>>> >>>>> So add @Ignore to that one test. >>>>> >>>>> Ralph >>>>> >>>>>> On Dec 9, 2019, at 10:18 PM, Gary Gregory <[email protected]> >>>>> wrote: >>>>>> >>>>>> The problem is that it prevents from running a full build on Windows in >>>>>> sane manner. I can skip the tests but that does not give me confidence >>>>> :-( >>>>>> >>>>>> Gary >>>>>> >>>>>> On Mon, Dec 9, 2019 at 10:49 PM Ralph Goers <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> Having looked at the test it is checking for “\n\t” in the result. The >>>>>>> test should not do that. I will modify it but I don’t think that is a >>>>>>> reason to block the release, assuming it gets enough votes. >>>>>>> >>>>>>> Ralph >>>>>>> >>>>>>>> On Dec 9, 2019, at 8:44 PM, Ralph Goers <[email protected]> >>>>>>> wrote: >>>>>>>> >>>>>>>> OK, that test was added 2 days after the last release in August. I >>>>> guess >>>>>>> that means you haven’t done a full build since then? >>>>>>>> >>>>>>>> Ralph >>>>>>>> >>>>>>>>> On Dec 9, 2019, at 8:42 PM, Ralph Goers <[email protected]> >>>>>>> wrote: >>>>>>>>> >>>>>>>>> Oh wait, I am looking at the wrong class. Let me check again. >>>>>>>>> >>>>>>>>> Ralph >>>>>>>>> >>>>>>>>>> On Dec 9, 2019, at 8:40 PM, Ralph Goers <[email protected]> >>>>>>> wrote: >>>>>>>>>> >>>>>>>>>> That test class hasn’t been modified since the last release. I >>>>>>> obviously don’t get that error on my Mac and I have run the build many >>>>>>> times, so it must be something Windows related. Is that the only problem >>>>>>> you encountered with the release? >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Ralph >>>>>>>>>> >>>>>>>>>>> On Dec 9, 2019, at 12:28 PM, Gary Gregory <[email protected]> >>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>> I get this failure running 'mvn clean package': >>>>>>>>>>> >>>>>>>>>>> [ERROR] Failures: >>>>>>>>>>> [ERROR] LoggerTest.builder:69 Incorrect message 3 >>>>>>>>>>> Expected: a string starting with " WARN Log4j rocks! >>>>>>> java.lang.Throwable: >>>>>>>>>>> This is a test\n\tat >>>>>>>>>>> org.apache.logging.log4j.LoggerTest.builder(LoggerTest.java:65)" >>>>>>>>>>> but: was " WARN Log4j rocks! java.lang.Throwable: This is a test >>>>>>>>>>> at >>>>> org.apache.logging.log4j.LoggerTest.builder(LoggerTest.java:65) >>>>>>>>>>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) >>>>>>>>>>> at >>>>>>>>>>> >>>>>>> >>>>> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) >>>>>>>>>>> at >>>>>>>>>>> >>>>>>> >>>>> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) >>>>>>>>>>> at java.lang.reflect.Method.invoke(Method.java:498) >>>>>>>>>>> at >>>>>>>>>>> >>>>>>> >>>>> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50) >>>>>>>>>>> at >>>>>>>>>>> >>>>>>> >>>>> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) >>>>>>>>>>> at >>>>>>>>>>> >>>>>>> >>>>> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47) >>>>>>>>>>> at >>>>>>>>>>> >>>>>>> >>>>> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) >>>>>>>>>>> at >>>>>>>>>>> >>>>>>> >>>>> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) >>>>>>>>>>> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) >>>>>>>>>>> at >>>>>>>>>>> >>>>>>> >>>>> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78) >>>>>>>>>>> at >>>>>>>>>>> >>>>>>> >>>>> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57) >>>>>>>>>>> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) >>>>>>>>>>> at >>>>> org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) >>>>>>>>>>> at >>>>>>> org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) >>>>>>>>>>> at >>>>> org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) >>>>>>>>>>> at >>>>>>> org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) >>>>>>>>>>> at org.junit.runners.ParentRunner.run(ParentRunner.java:363) >>>>>>>>>>> at >>>>>>>>>>> >>>>>>> >>>>> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365) >>>>>>>>>>> at >>>>>>>>>>> >>>>>>> >>>>> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273) >>>>>>>>>>> at >>>>>>>>>>> >>>>>>> >>>>> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238) >>>>>>>>>>> at >>>>>>>>>>> >>>>>>> >>>>> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159) >>>>>>>>>>> at >>>>>>>>>>> >>>>>>> >>>>> org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384) >>>>>>>>>>> at >>>>>>>>>>> >>>>>>> >>>>> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345) >>>>>>>>>>> at >>>>>>>>>>> >>>>>>> >>>>> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126) >>>>>>>>>>> at >>>>>>>>>>> >>>>>>> >>>>> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418) >>>>>>>>>>> " >>>>>>>>>>> [INFO] >>>>>>>>>>> [ERROR] Tests run: 643, Failures: 1, Errors: 0, Skipped: 3 >>>>>>>>>>> >>>>>>>>>>> Maybe this test has some hard-coded EOLs? >>>>>>>>>>> >>>>>>>>>>> Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) >>>>>>>>>>> Maven home: C:\Java\apache-maven-3.6.3\bin\.. >>>>>>>>>>> Java version: 1.8.0_231, vendor: Oracle Corporation, runtime: >>>>>>> C:\Program >>>>>>>>>>> Files\Java\jdk1.8.0_231\jre >>>>>>>>>>> Default locale: en_US, platform encoding: Cp1252 >>>>>>>>>>> OS name: "windows 10", version: "10.0", arch: "amd64", family: >>>>>>> "windows" >>>>>>>>>>> >>>>>>>>>>> Gary >>>>>>>>>>> >>>>>>>>>>> Gary >>>>>>>>>>> >>>>>>>>>>> On Mon, Dec 9, 2019 at 12:16 AM Ralph Goers < >>>>>>> [email protected]> >>>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> This is a vote to release Log4j 2.13.0, the next version of the >>>>>>> Log4j 2 >>>>>>>>>>>> project. >>>>>>>>>>>> >>>>>>>>>>>> Please download, test, and cast your votes on the log4j developers >>>>>>> list. >>>>>>>>>>>> [] +1, release the artifacts >>>>>>>>>>>> [] -1, don't release because... >>>>>>>>>>>> >>>>>>>>>>>> The vote will remain open for 72 hours (or more if required). All >>>>>>> votes >>>>>>>>>>>> are welcome and we encourage everyone to test the release, but only >>>>>>> Logging >>>>>>>>>>>> PMC votes are “officially” counted. As always, at least 3 +1 votes >>>>>>> and more >>>>>>>>>>>> positive than negative votes are required. >>>>>>>>>>>> >>>>>>>>>>>> Changes in this release include: >>>>>>>>>>>> >>>>>>>>>>>> New Features >>>>>>>>>>>> >>>>>>>>>>>> • LOG4J2-2732: Add ThreadContext.putIfNotNull method. Thanks to >>>>>>>>>>>> Matt Pavlovich. >>>>>>>>>>>> • LOG4J2-2731: Add a Level Patttern Selector. >>>>>>>>>>>> • LOG4J2-63: Add experimental support for Log4j 1 configuration >>>>>>>>>>>> files. >>>>>>>>>>>> • LOG4J2-2716: Add the ability to lookup Kubernetes attributes >>>>> in >>>>>>>>>>>> the Log4j configuration. Allow Log4j properties to be retrieved >>>>> from >>>>>>> the >>>>>>>>>>>> Spring environment if it is available. >>>>>>>>>>>> • LOG4J2-2710: Allow Spring Boot application properties to be >>>>>>>>>>>> accessed in the Log4j 2 configuration. Add lower and upper case >>>>>>> Lookups. >>>>>>>>>>>> • LOG4J2-2639: Add builder pattern to Logger interface. >>>>>>>>>>>> Fixed Bugs >>>>>>>>>>>> >>>>>>>>>>>> • LOG4J2-2058: Prevent recursive calls to >>>>>>>>>>>> java.util.LogManager.getLogger(). >>>>>>>>>>>> • LOG4J2-2725: LOG4J2-2725 - Added try/finally around >>>>>>>>>>>> event.execute() for RingBufferLogEventHandler to clear memory >>>>>>> correctly in >>>>>>>>>>>> case of exception/error Thanks to Dzmitry Anikechanka. >>>>>>>>>>>> • LOG4J2-2635: Wrong java version check in >>>>>>>>>>>> ThreadNameCachingStrategy. Thanks to Filipp Gunbin. >>>>>>>>>>>> • LOG4J2-2674: Use a less confusing name for the >>>>>>>>>>>> CompositeConfiguration source. Thanks to Anton Korenkov. >>>>>>>>>>>> • LOG4J2-2727: Add setKey method to Kafka Appender Builder. >>>>>>> Thanks >>>>>>>>>>>> to Clément Mathieu. >>>>>>>>>>>> • LOG4J2-2707: ArrayIndexOutOfBoundsException could occur with >>>>>>> MAC >>>>>>>>>>>> address longer than 6 bytes. Thanks to Christian Frank. >>>>>>>>>>>> • LOG4J2-2712: The rolling file appenders would fail to compress >>>>>>>>>>>> the file after rollover if the file name matched the file pattern. >>>>>>>>>>>> • LOG4J2-2693: @PluginValue does not support attribute names >>>>>>>>>>>> besides "value". >>>>>>>>>>>> • LOG4J2-2647: Validation blocks definition of script in >>>>>>>>>>>> properties configuration. >>>>>>>>>>>> • LOG4J2-2680: Set result of rename action to true if file was >>>>>>>>>>>> copied. Thanks to Guillermo Xavier Hurtado Garcia. >>>>>>>>>>>> • LOG4J-2672: Add automatic module names where missing. Thanks >>>>> to >>>>>>>>>>>> Stephen Colebourne. >>>>>>>>>>>> • LOG4J2-2673: OutputStreamAppender.Builder ignores setFilter(). >>>>>>>>>>>> Thanks to Yuichi Sugimura. >>>>>>>>>>>> • LOG4J2-2725: Prevent a memory leak when async loggers throw >>>>>>>>>>>> errors. Thanks to Dzmitry Anikechanka. >>>>>>>>>>>> Changes >>>>>>>>>>>> >>>>>>>>>>>> • LOG4J2-2701: Update Jackson to 2.9.10. >>>>>>>>>>>> • LOG4J2-2709: Allow message portion of GELF layout to be >>>>>>>>>>>> formatted using a PatternLayout. Allow ThreadContext attributes to >>>>> be >>>>>>>>>>>> explicitly included or excluded in the GelfLayout. >>>>>>>>>>>> >>>>>>>>>>>> Tag: >>>>>>>>>>>> a) for a new copy do "git clone >>>>>>>>>>>> https://github.com/apache/logging-log4j2.git"; and then "git >>>>> checkout >>>>>>>>>>>> tags/log4j-2.13.0-rc1” >>>>>>>>>>>> b) for an existing working copy to “git pull” and then “git >>>>> checkout >>>>>>>>>>>> tags/log4j-2.13.0-rc1” >>>>>>>>>>>> >>>>>>>>>>>> Web Site: http://rgoers.github.io/log4j2-site/index.html. >>>>>>>>>>>> >>>>>>>>>>>> Maven Artifacts: >>>>>>>>>>>> >>>>>>> >>>>> https://repository.apache.org/content/repositories/orgapachelogging-1049 >>>>>>>>>>>> >>>>>>>>>>>> Distribution archives: >>>>>>>>>>>> https://dist.apache.org/repos/dist/dev/logging/log4j/ >>>>>>>>>>>> >>>>>>>>>>>> You may download all the Maven artifacts by executing: >>>>>>>>>>>> wget -e robots=off --cut-dirs=7 -nH -r -p -np >>>>> --no-check-certificate >>>>>>>>>>>> >>>>>>> >>>>> https://repository.apache.org/content/repositories/orgapachelogging-1049/org/apache/logging/log4j/ >>>>>>>>>>>> >>>>>>>>>>>> Ralph >>>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>> >>>>> >>>>> >>> >>> >>> >> >> -ck > > >
