No worries, in the mean time I will try to 1. submit a PR to JCTools 2. re-do benchmarks 3. implement GcFreeJsonTemplateLayoutTest
On Wed, Mar 11, 2020 at 4:05 PM Ralph Goers <[email protected]> wrote: > > Also, I have to apologize that I have not yet reviewed the PR. I promise I > will but it will take a while with 97 files being modified. > > Ralph > > > On Mar 11, 2020, at 8:01 AM, Ralph Goers <[email protected]> wrote: > > > > > >> On Mar 11, 2020, at 7:09 AM, Volkan Yazıcı <[email protected]> wrote: > >> > >> I have finally removed all dependencies of JsonTemplateLayout, except > >> for optional JCTools dependency. I have a couple of questions to > >> proceed further: > >> > >> 1. May I move the code in the module to core? > >> 2. Shall I remove benchmark results in the manual since > >> it is difficult to keep them up to date? > >> > > > > 1. Did you lose functionality by removing the dependencies? > > 2. Did you have to add things like JSON parsing to remove the dependencies? > > 3. Under what circumstances is JCTools optional? > > 4. Does JCTools provide a module-info.class or Automatic-Module-Name header > > in MANIFEST.MF? I am in the process of modularizing core in master and some > > of our optional dependencies don’t and the code related to them will have > > to move out of core. > > > > The goal should not be to move things to core. The goal should be to make > > them simple for users to integrate. > > > > As for benchmarks, if you have current benchmarks then include them. They > > don’t have to be updated with each release but the page should indicate > > what release they were for. > > > > Speaking of documentation, if you are creating a separate page or pages for > > JsonTemplateLayout make sure there is an entry in the general Layout page > > that has a general description and a link to the full documentation. > > > > Ralph > > > > > > > >
