None of the references were included in the email I see in my Mac Mail client. Were they included?
Ralph > On Mar 11, 2020, at 8:19 AM, Volkan Yazıcı <[email protected]> wrote: > > My comments are inline. > > On Wed, Mar 11, 2020 at 4:01 PM Ralph Goers <[email protected]> > wrote: >> 1. Did you lose functionality by removing the dependencies? > > Except pretty printing, no. > >> 2. Did you have to add things like JSON parsing to >> remove the dependencies? > > Yes, I have implemented simple JsonReader[1] and JsonWriter[2] > classes. Both are well tested[3][4]. > >> 3. Under what circumstances is JCTools optional? > > User can pick different allocation strategies: dummy, thread-local, > and queue. "queue" also accepts an optional "java.util.Queue(int > capacity)" factory method parameter. There, by default, if JCTools is > in the classpath, we use MpmcArrayQueue; otherwise fallback to > ArrayBlockingQueue. (The user can also explicitly demand and enforce > the queue.) The logic is available here[5]. > >> 4. Does JCTools provide a module-info.class or >> Automatic-Module-Name header in MANIFEST.MF? > > As you know[6] better than I do, no. > >> The goal should not be to move things to core. The goal should >> be to make them simple for users to integrate. > > I will interpret this as "keep it in the module". > >> As for benchmarks, if you have current benchmarks >> then include them. They don’t have to be updated with >> each release but the page should indicate what release >> they were for. > > Okay. > >> Speaking of documentation, if you are creating a separate >> page or pages for JsonTemplateLayout make sure there is >> an entry in the general Layout page that has a general >> description and a link to the full documentation. > > Yes, I have implemented it as you described. >
