Yes, when merging PRs changes.xml needs to be modified. When I am performing a release I have no way of knowing that a PR as not included in the changes, nor would I want to spend the time researching that.
I would suggest that when updating a dependency version that the changes.xml for the current version be checked to see if the same component is already there and then just update that. Ralph > On Jul 2, 2020, at 7:13 AM, Gary Gregory <[email protected]> wrote: > > Personally, in most projects, I update changes.xml with my commits, and for > PRs as a follow up commit. It is that much less for the release manager to > do IMO. > > What I do not ask is for contributors to updates changes.xml in PRs because > that creates conflicts most of the time. > > Gary > > On Thu, Jul 2, 2020, 08:36 Carter Kozak <[email protected]> wrote: > >> I wonder if we should wait until we're ready to cut a release to update >> the changelog with dependency changes? That way we don't end up with >> changelog entries for all intermediate versions of dependencies. The >> release process is already relatively heavy and adding more friction to >> ship a release isn't a great solution either. >> >> -ck >> >> On Thu, Jul 2, 2020, at 08:30, Gary Gregory wrote: >>> That's fine with me. You will want to update changes.xml to track >> changes. >>> >>> Gary >>> >>> On Thu, Jul 2, 2020, 04:10 Volkan Yazıcı <[email protected]> >> wrote: >>> >>>> Hello, >>>> >>>> 1. I will approve GitHub dependabot PRs that pass the CI tests. >>>> 2. I will (blindly?) cherry-pick them onto release-2.x. >>>> >>>> Objections? >>>> >>>> Kind regards. >>>> >>> >>
