The changes.xml creates the Manual changes page at http://logging.apache.org/log4j/2.x/changes-report.html#a2.13.3 <http://logging.apache.org/log4j/2.x/changes-report.html#a2.13.3>. I suspect if the issue number is not a Jira issue it will generate a bad link. That is partly why we always create Jira issues for PRs. It also makes searching for fixes easier as we only need to search one place (Jira).
We don’t use the GitHub issue tracking system. I am not sure if any ASF projects do. Ralph > On Jul 2, 2020, at 5:59 AM, Volkan Yazıcı <[email protected]> wrote: > > Doh! I have totally missed changes.xml updates while approving GitHub > PRs. There I only see JIRA ticket ids as "action.issue" attributes. > May I also use GitHub issue ids too? If so, do I need to prefix them > with `#`? > > On Thu, Jul 2, 2020 at 2:30 PM Gary Gregory <[email protected]> wrote: >> >> That's fine with me. You will want to update changes.xml to track changes. >> >> Gary >> >> On Thu, Jul 2, 2020, 04:10 Volkan Yazıcı <[email protected]> wrote: >> >>> Hello, >>> >>> 1. I will approve GitHub dependabot PRs that pass the CI tests. >>> 2. I will (blindly?) cherry-pick them onto release-2.x. >>> >>> Objections? >>> >>> Kind regards. >>> >
