I mean, even though some guy make it fails locally, CI shall stop manager for merging that pr, shouldn't it?
XenoAmess ________________________________ From: Xeno Amess <[email protected]> Sent: Monday, May 2, 2022 9:23:11 PM To: [email protected] <[email protected]> Subject: Re: Please verify your stuff. I don't understand. What is CI doing? XenoAmess ________________________________ From: Ralph Goers <[email protected]> Sent: Monday, May 2, 2022 8:58:50 PM To: [email protected] <[email protected]> Subject: Please verify your stuff. Remko, Did you run a full build of master when you committed your latest changes? I don’t see how. I am getting failures in XmlSchemaTest. It seems AsyncWaitStrategyIncorrectFactoryConfigTest.xml, AsyncWaitStrategyFactoryConfigGlobalLoggerTest.xml, AsyncWaitStrategyFactoryConfigTest.xml, and AsyncWaitStrategyIncorrectFactoryConfigGlobalLoggerTest.xml include a new AsyncWaitStrategyFactory element that the Log4j schema is not aware of. I am fixing this as I also added a new element that is causing it to fail. However, I also got merge conflicts when merging release-2.x so I will need to re-run my build there to see if the same problem was added. Ralph
