We don't block PRs or commits based on CI status. We use CTR, so it's the responsibility of each committer to run the tests locally before pushing upstream.
It also doesn't help that as of now, CI takes 4x as long to build and run the tests than it does on my machine. Plus, CI is flaky sometimes (there are still some tests that seem to break when under high load due to how said tests are written). Now if we can't maintain a level of discipline of keeping the main branches green, then perhaps we can revisit the workflow here, but this is a rare occurrence. On Mon, May 2, 2022 at 8:25 AM Xeno Amess <xenoam...@gmail.com> wrote: > > I mean, even though some guy make it fails locally, CI shall stop manager for > merging that pr, shouldn't it？ > > XenoAmess > ________________________________ > From: Xeno Amess <xenoam...@gmail.com> > Sent: Monday, May 2, 2022 9:23:11 PM > To: dev@logging.apache.org <dev@logging.apache.org> > Subject: Re: Please verify your stuff. > > I don't understand. > What is CI doing？ > > XenoAmess > ________________________________ > From: Ralph Goers <ralph.go...@dslextreme.com> > Sent: Monday, May 2, 2022 8:58:50 PM > To: dev@logging.apache.org <dev@logging.apache.org> > Subject: Please verify your stuff. > > Remko, > > Did you run a full build of master when you committed your latest changes? I > don’t see how. > I am getting failures in XmlSchemaTest. It seems > AsyncWaitStrategyIncorrectFactoryConfigTest.xml, > AsyncWaitStrategyFactoryConfigGlobalLoggerTest.xml, > AsyncWaitStrategyFactoryConfigTest.xml, > and AsyncWaitStrategyIncorrectFactoryConfigGlobalLoggerTest.xml include a new > AsyncWaitStrategyFactory element that the Log4j schema is not aware of. > > I am fixing this as I also added a new element that is causing it to fail. > However, I also got merge > conflicts when merging release-2.x so I will need to re-run my build there to > see if the same problem > was added. > > Ralph
