What is the thing exactly cluttering here? It is as transparent as it can possibly get.
Regarding `maven-assembly-plugin`... I simply don't get the motivation behind replacing `git ls-files | zip` with hundreds of lines of XML containing ad-hoc include/exclude statements in a module that needs to be excluded in various other `pom.xml` files of the project. Not to mention its configuration needs to be maintained manually and there have been occasions in the past where certain modules were forgotten to be added and got noticed at the last minute. Mind sharing advantages of this sophistication over a bash one-liner? On Tue, May 2, 2023 at 9:44 PM Gary Gregory <garydgreg...@gmail.com> wrote: > Uh? It should NOT contain an exact copy of a git repository, what do I need > a ".github" folder for in order to build the project? I don't, it just > clutter things up for no good reason. None of the Apache projects I've seen > do this. It sounds like a convenience because it's easy as opposed to using > a proper Maven assembly plugin configuration with a bin.xml file and a > src.xml file. > > Gary > > On Tue, May 2, 2023, 15:12 Volkan Yazıcı <vol...@yazi.ci> wrote: > > > I completely disagree. Generated ZIP archive contains _an exact copy_ of > > the repository snapshot used to generate the release. (In a nutshell, it > is > > `git ls-files | zip` output.) > > > > Contrast this with Log4j, which bundles everything out there using the > > provided configuration composed of dozens of lines of exclude statements. > > > > On Tue, May 2, 2023 at 5:17 PM Gary D. Gregory <ggreg...@apache.org> > > wrote: > > > > > Another needed clean-up (not a blocker): The zip file has all sorts of > > git > > > junk: a .github folder, a .gitignore file, and a .mvn folder (I > certainly > > > don't want extra maven junk either but that's just me)? There should > only > > > _sources_, not a snapshot of all files in the github repo. For example, > > see > > > > > > https://dlcdn.apache.org/logging/log4j/2.20.0/apache-log4j-2.20.0-bin.zip > > > > > > Gary > > > > > > > > > On 2023/05/01 19:09:37 "Piotr P. Karwasz" wrote: > > > > The Apache Log4j Transformation Tools 0.1.0 release is now available > > for > > > voting. > > > > > > > > This is the first release and it contains two modules: > > > > > > > > * [LOG4J2-3638]: Adds a bytecode transformation tool to provide > > > > location information without reflection. > > > > * [LOG4J2-673]: Adds a resource transformer for the Maven Shade > Plugin > > > > to merge `Log4j2Plugins.dat` plugin caches. Thanks to Eduard > > > > Gizatullin. > > > > > > > > Source repository: https://github.com/apache/logging-log4j-transform > > > > Tag: rel/0.1.0-rc2 > > > > Commit: 7bb767c1466cd9faebfeeffa8136b231bf2b6fae > > > > Artifacts: > > > https://dist.apache.org/repos/dist/dev/logging/log4j-transform/0.1.0 > > > > Nexus repository: > > > > > > https://repository.apache.org/content/repositories/orgapachelogging-1104 > > > > CI job run: > > > > > > https://github.com/apache/logging-log4j-transform/actions/runs/4853722893 > > > > Signing key: > > > > > > https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0&fingerprint=on&op=index > > > > > > > > Please download, test, and cast your votes on the Log4j developers > > list. > > > > > > > > [ ] +1, release the artifacts > > > > [ ] -1, don't release, because... > > > > > > > > The vote will remain open for 72 hours All votes are welcome and we > > > > encourage everyone to test the release, but only the Logging Services > > > > PMC votes are officially counted. At least 3 +1 votes and more > > > > positive than negative votes are required. > > > > > > > > Countdown: > > > > > > https://www.timeanddate.com/countdown/launch?iso=20230504T2115&p0=4162&font=cursive > > > > > > > > Piotr > > > > > > > > > >
