Hi all, On Wed, 8 Nov 2023 at 09:05, Volkan Yazıcı <vol...@yazi.ci> wrote: > I completely agree with Matt. With or without IDE plugins, we run `./mvnw > spotless:apply` anyway. Hence, lack of Eclipse support is not a blocker, > IMO. Gary is covered. > > +1 deterministic formatter (don't have an opinion on Palantir-vs-Google) > > Piotr, it has been two months or so since we are discussing this. No > objections so far. Please go ahead and implement this. It will help a lot > for sync'ing `2.x` and `3.x`.
I submitted a PR against `palantir-java-formatter`: https://github.com/palantir/palantir-java-format/pull/949 It's an independent Maven project, so it can be used to generate an Eclipse plugin that "works for me". Gary can you check if it works for you? It might take me a while to integrate that into Palantir's Gradle build. If you have mad Gradle skills, feel free to get a crack at it. As far as I can tell, the only "hard" operation is retrieving the `org.eclipse.jdt.core` artifact from a P2 repository to use in the compilation step. The remaining steps are copying a bunch of resources and three dependency libraries into the JAR. +1 I consider this task accomplished and I'll start deploying the Palantir formatter to our repos next week. Piotr
