+1 Skimmed through https://logging.staged.apache.org/log4cxx ✅ `shasum --check *.512` ✅ `for sigFile in *.asc; do gpg --verify $sigFile; done` ✅ `cmake . && make && make test` ✅
I was keeping an eye on log4cxx commits, great activity! Kudos to Robert and Stephen! 🙇♂️ Nitpicks: - `make test` took 42 seconds, where it spent 23 seconds on the `asyncappendertestcase`. Too many `sleep()` calls? - Changelog date is missing in https://logging.staged.apache.org/log4cxx/latest_stable/changelog.html I presume this will be fixed with the release. There the sectioning is also broken, AFAIC. See sections named `Bug`, `Improvement`, `Wish`, etc. - I wish Stephen, who has been freshly admitted to the PMC, would have done the release. This would be a good opportunity to spread the know-how. Maybe it is still not too late? Maybe he can do the rest of the procedure? On Fri, Dec 29, 2023 at 1:01 AM Robert Middleton <[email protected]> wrote: > This is a vote to release log4cxx 1.2.0-RC1. > > Please download, test, and cast your votes on the log4j developers list. > [] +1, release the artifacts > [] -1, don't release because... > > This vote will remain open for 72 hours(or more if required). > > All votes are welcome and we encourage everyone to test the release, > but only Logging PMC votes are “officially” counted. As always, at > least 3 +1 votes and more positive than negative votes are required. > > A quick changelog is below: > * Various build failures have been fixed > * Added a new Hexdump utility method to dump arbitrary memory > * Fixed a segfault when shutting down and not stopping the library > * QStrings may now be logged directly > * The main namespace is now configurable from log4cxx to any value > that is desired > > Tag: > For a new copy do "git clone > https://github.com/apache/logging-log4cxx.git"; and then "git checkout > tags/v1.2.0-RC1" > For an existing working copy, do "git pull" and then "git checkout > tags/v1.2.0-RC1" > > Web site: https://logging.staged.apache.org/log4cxx/latest_stable/ > > Distribution archives: > https://dist.apache.org/repos/dist/dev/logging/log4cxx/ > > Building directions are on the website(under 'Development'). Note > that APR is required to build(as well as boost if your compiler does > not support C++17). > > -Robert Middleton >
