+1

I have:
- checked the SHA512 checksums
- checked for unexpected changes in the list of files in the 1.2.0.tar.gz
archive compared to the 1.1.0.tar.gz release archive
- built on Windows using each compressed archive (using two conan recipes)
- built and tested a suite of applications using log4cxx 1.2.0 release

.

<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
Virus-free.www.avast.com
<https://www.avast.com/sig-email?utm_medium=email&utm_source=link&utm_campaign=sig-email&utm_content=webmail>
<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

On Sat, Dec 30, 2023 at 9:36 AM Volkan Yazıcı <vol...@yazi.ci> wrote:

> Thanks for the prompt response Robert. Appreciated the pointers. Log4cxx
> docs are indeed helpful. But a little bit more guidance in the vote email
> could be helpful.
>
> See that two other people (Piotr and Matt) quickly reviewed the release
> after my email sharing the steps I followed
> <https://lists.apache.org/thread/qk00xgx1kf1jcmblhkb865dgng933mb0>. I
> think
> this vividly demonstrates my case.
>
> On Fri, Dec 29, 2023 at 4:20 PM Robert Middleton <rmiddle...@apache.org>
> wrote:
>
> > 1. staging website was in the email
> > 2/3: I use this script to verify things.  Feel free to adapt for your
> > own purposes:
> > https://gist.github.com/rm5248/b2abba4bb4f1d9cf518be49d064a0be1
> > 4. Build instructions are on the website:
> > https://logging.staged.apache.org/log4cxx/latest_stable/build-cmake.html
> >
> > Let me know if you want help on doing the build/test.  Linux is the
> > easiest, OSX should be pretty easy, and Windows can be difficult.  The
> > Github actions do a build and test for all 3 of those platforms.
> >
> > -Robert Middleton
> >
> > On Fri, Dec 29, 2023 at 4:04 AM Volkan Yazıcı <vol...@yazi.ci> wrote:
> > >
> > > I would really appreciate a "review kit" for voting on log4cxx
> releases:
> > >
> > >    1. Where is the staging website?
> > >    2. How can I verify the checksum?
> > >    3. How can I verify the signatures?
> > >    4. How can I build and test the sources?
> > >
> > > (For inspiration, you can check out the review kit we use for
> Java-based
> > > projects
> > > <
> >
> https://github.com/apache/logging-parent/blob/main/.github/release-review-kit.txt
> > >
> > > .)
> > >
> > > Maybe there are more things I should be reviewing, but I simply don't
> > know.
> > > Hence, making your expectations clear from a review would not only help
> > > reviewers, but, IMHO, improve the engagement.
> > >
> > > ---------- Forwarded message ---------
> > > From: Robert Middleton <rmiddle...@apache.org>
> > > Date: Fri, Dec 29, 2023 at 1:01 AM
> > > Subject: [VOTE] Release log4cxx 1.2.0-RC1
> > > To: <dev@logging.apache.org>
> > >
> > >
> > > This is a vote to release log4cxx 1.2.0-RC1.
> > >
> > > Please download, test, and cast your votes on the log4j developers
> list.
> > > [] +1, release the artifacts
> > > [] -1, don't release because...
> > >
> > > This vote will remain open for 72 hours(or more if required).
> > >
> > > All votes are welcome and we encourage everyone to test the release,
> > > but only Logging PMC votes are “officially” counted. As always, at
> > > least 3 +1 votes and more positive than negative votes are required.
> > >
> > > A quick changelog is below:
> > > * Various build failures have been fixed
> > > * Added a new Hexdump utility method to dump arbitrary memory
> > > * Fixed a segfault when shutting down and not stopping the library
> > > * QStrings may now be logged directly
> > > * The main namespace is now configurable from log4cxx to any value
> > > that is desired
> > >
> > > Tag:
> > > For a new copy do "git clone
> > > https://github.com/apache/logging-log4cxx.git"; and then "git checkout
> > > tags/v1.2.0-RC1"
> > > For an existing working copy, do "git pull" and then "git checkout
> > > tags/v1.2.0-RC1"
> > >
> > > Web site: https://logging.staged.apache.org/log4cxx/latest_stable/
> > >
> > > Distribution archives:
> > > https://dist.apache.org/repos/dist/dev/logging/log4cxx/
> > >
> > > Building directions are on the website(under 'Development').  Note
> > > that APR is required to build(as well as boost if your compiler does
> > > not support C++17).
> > >
> > > -Robert Middleton
> >
>

Reply via email to