> On Jan 18, 2024, at 9:01 AM, Piotr P. Karwasz <piotr.karw...@gmail.com> wrote:
>
> Hi Ralph,
>
> On Thu, 18 Jan 2024 at 15:56, Ralph Goers <ralph.go...@dslextreme.com> wrote:
>> Spring uses PropertiesUtil. I suspect it isn’t alone. That would mean
>> anything impacted by the property changes would have to be in the spi or
>> abstracted to reference something in the spi. I am assuming a log4j-spi-2.x
>> would also be needed. There are many other utility classes that have never
>> been off limits for users to use.
>>
>> While your idea could work it definitely would impact some users.
>
> Spring Boot contributors were probably aware that `PropertiesUtil` is
> not part of the public API. ;-)
Well, I contributed the PR and have always assumed PropertiesUtil was public.
They modified my PR to limit the scope of the PropertySource but not much more
than that.
> Besides we already broke their code, when 2.7 introduced breaking
> changes to ConfigurationFactory.
? The contribution I made was done last year - long past 2.7.
> I am more afraid about users calling `LogManager#getContext` and other
> magical snippets of code that I don't consider being part of the
> public API (that method should have probably been protected from the
> start).
Except tons of users call it for some reason.
>
> In 2022 we saw a lot of questions about users looking to replace
> `PropertyConfigurator` from 1.x. Unless I am mistaken, calling
> `PropertyConfigurator` was not required since Log4j 1.0.
I am not sure what that has to do with the rest of your points.
Ralph
