What about the failure? Gary
On Fri, Mar 15, 2024, 11:35 AM Davyd McColl <dav...@gmail.com> wrote: > Hi > > Yes, everything should be done via npm scripts. So I should remove any > confusing .cmd files. > > As for the version, I should update that, but it's minor. That version > comes from package.json and will only show when running npm commands. But I > admit it's confusing. > > -d > > On 15 March 2024 16:28:47 "Gary D. Gregory" <ggreg...@apache.org> wrote: > >> We might need better build instructions... for me at least ;-) >> >> I take it the build.cmd file should be removed since it's not mentioned >> in https://github.com/apache/logging-log4net/blob/master/doc/BUILDING.md >> ? >> >> BUILDING.md contains a section called "TL;DR (!Windows):" which is too >> easy to confuse with "TL;DR (Windows):", just say "TL;DR (non-Windows):", >> there is no need to be clever here IMO. >> >> When I say "npm i" and then "npm run build", it starts with: >> >>> log4net@2.0.12 prebuild >>> run-s clean-build >>> log4net@2.0.12 clean-build >>> rimraf build >>> log4net@2.0.12 build >>> zarro @ >>> >> >> Why does it say log4net@2.0.12 when I am building 2.0.17? >> >> Then the build errors out with https://paste.apache.org/1ropz >> >> I, off course, don't know what I'm doing with .net... ;-) >> >> Gary >> >> On 2024/03/15 12:28:03 Davyd McColl wrote: >> >>> Hi all, >>> >>> This is a vote to release the Apache Log4net 2.0.17. >>> >>> Website: >>> https://logging.staged.apache.org/log4net/release/release-notes.html >>> GitHub: https://github.com/apache/logging-log4net >>> GitHub release (pre-release): >>> https://github.com/apache/logging-log4net/releases/tag/rel/2.0.17-rc1 >>> Distribution: https://dist.apache.org/repos/dist/dev/logging/log4net >>> >>> Please download, test, and cast your votes on this mailing list. >>> >>> [ ] +1, release the artifacts >>> [ ] -1, don't release, because... >>> >>> This vote is open for 72 hours and will pass unless getting a >>> net negative vote count. All votes are welcome and we encourage >>> everyone to test the release, but only the Logging Services PMC >>> votes are officially counted. >>> >>> Thanks to Jan for basically doing all of this (: >>> >>> -d >>> >>
