Hi Stephen, thanks for your feedback. I've incorporated it into https://logging.staged.apache.org/log4net/release/release-review-instructions.html
Jan On 21 October 2024 03:08:33 CEST, Stephen Webb <swebb2...@gmail.com> wrote: >+1 > >I have successfully verified the release on my WIndows 11 machine. > >The checksums are correct, the signature is correct and the tests all passed. > >Suggested improvements to release instructions: >1. Require gpg install/bin directory to be in the path. The >GnuPG.Gpg4win installer does not add to the path. >2. Require an svn install rather than specifically TortoiseSVN (I used SlikSvn) >3. Specify the required working directory for the tests in the >instructions rather than the pushd at the end of >verify-release.ps1(The command line in verify-release.ps1 >$VersionDirectory = "$Directory/src/$(@(Get-ChildItem >$Directory/src)[0])" does not work on my system.) >4. Decouple release-review instructions from the product documentation >(e.g. Use a Markdown file in Github) (I also had to work out the fix >you put in >https://github.com/apache/logging-log4net/commit/2d610393b9e4b53d0c139bf60f1547af050bee29) > >Stephen > >On Sun, Oct 20, 2024 at 4:21 PM Piotr P. Karwasz ><piotr.karw...@gmail.com> wrote: >> >> Hi Jan, >> >> On Fri, 18 Oct 2024 at 11:24, Jan Friedrich <freeand...@apache.org> wrote: >> > Website: >> > https://logging.staged.apache.org/log4net/release/release-notes.html >> > GitHub: https://github.com/apache/logging-log4net >> > Commit: d0d9c9ba88ac29be1d3f2174e47e50939819e60d >> > Distribution: https://dist.apache.org/repos/dist/dev/logging/log4net/3.0.2 >> > Signing key: 0x7D24496A230E29D6349A99EF583E491578F02D5D >> > Review kit: >> > https://logging.apache.org/log4net/release/release-review-instructions.html >> > >> > Please download, test, and cast your votes on this mailing list. >> > >> > [ ] +1, release the artifacts >> > [ ] -1, don't release, because ... >> >> +1, >> >> I could successfully verify the release using my Debian 12 with: >> >> * Mono package version 6.8.0.105+dfsg-3.3, >> * Dotnet version 8.0.403 >> >> I checked: >> >> * the hashes, >> * the signatures, >> * the tests. >> >> Piotr Jan
