I am finding this email confusing. I think it is due to the formatting but I am not sure. I am making my best guess.
Vote 1: Enable certain branch protection features on the code branches (`2.x` and `main`) of all non-dormant Java repos: I can’t vote on this as I don’t know what the impact of that is. Vote 2. Require conversation resolution before merging. +1 - This just makes sense on a PR. Why would you merge something with open questions? Vote 3. Require linear history (Prevent merge commits from being pushed to code branches. Only "Squash" and similar allowed) I need more discussion on this. Why do I care about merge commits to resolve conflicts (which frequently aren’t conflicting with Git). Vote 4. Require status checks to pass before merging +1 Again - this is on PRs. If we have defined a workflow to automatically perform tests/tasks before allowing a merge I see no reason not to require they all succeed. Ralph > On Apr 2, 2025, at 7:18 AM, Piotr P. Karwasz <pi...@mailing.copernik.eu> > wrote: > > Hi all, > > Trying to implement the RTC rules we discussed in September[1] I encountered > some problems due to the limitations of the currently available GitHub > Settings. This is a vote to decide whether or not enable certain branch > protection features on the code branches (`2.x` and `main`) of these repos: > > * l-admin * l-jdk * l-jmx-gui > * l-log4j2 * l-log4j-jakarta * l-log4j-kotlin * l-log4j-samples* > l-log4j-scala * l-log4j-transform * l-log4j-tools * l-parent > * l-slf4j > (i.e. all the Java repos except Chainsaw, Flume and Log4j Audit). The vote > will be open for 176 hours (1 week). Everybody can vote, but only binding > votes will be counted. It will concern the following features separately: > Require a pull request before merging: > [ ] +1, enable this feature > [ ] -1, do not enable this feature > Require conversation resolution before merging: > > [ ] +1, enable this feature > [ ] -1, do not enable this feature > Require linear history (Prevent merge commits from being pushed to code > branches. Only "Squash" and similar allowed): [ ] +1, enable this feature > [ ] -1, do not enable this feature > Require status checks to pass before merging: > > [ ] +1, enable this feature > [ ] -1, do not enable this feature > > Require at least one positive review before merging: > > [ ] +1, enable this feature > [ ] -1, do not enable this feature > > Piotr > > [1] https://lists.apache.org/thread/6gbos0rn3k4y3wjb1hcgnnols4ogqckl >
