Hi,
These are my votes:
On 2.04.2025 19:12, Piotr P. Karwasz wrote:
Vote 1. Require a pull request before merging:
[ ] +1, enable this feature
[ ] -1, do not enable this feature
+1
Vote 2. Require conversation resolution before merging:
[ ] +1, enable this feature
[ ] -1, do not enable this feature
+1
Vote 3. Require linear history (Prevent merge commits from being
pushed to code branches. Only "Squash" and similar allowed):
[ ] +1, enable this feature
[ ] -1, do not enable this feature
+0: I do like linear history, but in some situations (like merging a
bigger feature branch) it is just safer to do a merge instead of rebasing.
Note: for smaller feature branches I prefer rebasing.
Vote 4. Require status checks to pass before merging:
[ ] +1, enable this feature
[ ] -1, do not enable this feature
+1 and I'll work on flaky tests to make that easier.
Vote 5. Require at least one positive review before merging:
[ ] +1, enable this feature
[ ] -1, do not enable this feature
+1 and I hope enough people will start reviewing.
With this the result of the vote is:
Vote 1. Require a pull request before merging:
+4 (+1 from Jan, Ralph, Volkan and me, Gary abstained)
Vote 2. Require conversation resolution before merging:
+4 (+1 from Jan, Ralph, Volkan and me, Gary abstained)
Vote 3. Require linear history:
-0.9 (+1 from Volkan, -0.9 from Jan, -1 from Gary, Ralph and me abstained)
Vote 4. Require status checks to pass before merging:
+4 (+1 from Jan, Ralph, Volkan and me, Gary abstained)
Vote 5. Require at least one positive review before merging:
+2.5 (+1 from Jan, Volkan and me, -0.5 from Ralph, Gary abstained)
I will proceed implementing via PRs rules 1, 2, 4 and 5. It goes without
saying, somebody needs to review them.
Piotr
