Hi Matt,

On 16.10.2025 19:43, Matt Sicker wrote:
> Some of my PRs since then have indeed been reviewed or approved
> within a day or two (good), but some of them have sat for months
> without a single comment. Seeing as how we’ve disabled committing to
> main and 2.x directly, I can’t merge my own PR.
Thanks for raising this, Matt. I understand the frustration when reviews
take longer than expected and I agree that the current backlog can be
discouraging. However, I don’t think the core issue is RTC versus CTR,
but rather how we communicate and follow up on pending work.

Since the end of July, you’ve opened 13 PRs (thank you for all that effort):

- 9 were reviewed and resolved within a day or two,

- 3 have open questions that we’re still waiting for your feedback on.
By “feedback”, I mean either addressing the suggestion or letting us
know directly that you think it’s incorrect or out of scope. Two of
these ([1] and [2]) have been in that state for quite some time.

- And finally, there’s your GraalVM support PR for 3.x [3], which I
believe you’re referring to here.

That last one is entirely on me: I simply lost track of it, and I’m
sorry about that. Over the past couple of months, I’ve been juggling
work on the PackageURL draft (which brought an avalanche of
notifications) and quite a bit of activity in Commons. Still, that’s no
excuse for overlooking your contribution, and I’ll make it a top
priority now.

That said, communication goes both ways. If a PR is blocking your next
steps, please feel free to ping me directly: a quick reminder on GitHub
or Slack can really help keep things moving. As far as I can tell, you
didn't do either.

Finally, since you mentioned this PR is non-trivial (as noted in [4]), I
think it’s in everyone’s best interest to ensure it gets proper review
before merging. Allowing self-merges in such cases risks code slipping
through without shared understanding or validation, which helps no one
in the long run.

So, rather than changing the merge policy, I’d prefer we improve how we
coordinate and follow up on important PRs. That’s what really keeps
things moving, regardless of RTC or CTR.

Best,
Piotr

References:
[1] https://github.com/apache/logging-log4j2/pull/3869
[2] https://github.com/apache/logging-log4j2/pull/3877
[3] https://github.com/apache/logging-log4j2/pull/3884
[4] https://lists.apache.org/thread/rn0jxxmqcwh6wfk3c16hgvrbmdrf90lb

Reply via email to