On Mon, Oct 27, 2025, at 12:34, Volkan Yazıcı wrote:
> #3855 illustrates a PR reviewed by two maintainers, but not approved due to
> (objective) reasons. I am puzzled by the reaction advocating *"maintainers'
> contributions *must* be merged"*.
Good point.
So, I didn't see many valid reasons why the PR should not be merged.
I understand from Piotr that the PR is not complete, and other places should be
changed, and Gary volunteers to do so.
The question now is: who decides what is merged?
Rejecting a PR is an effective -1.
At the ASF, we rarely vote -1 on code changes. Doing so usually has strong
reasons. It always leads to problems (or almost), because it leads to the
question of who owns the codebase.
This question arose in earlier versions of Log4j and led to a technical
deadlock.
What would you do if I merged this PR?
Would it be acceptable for you?
I previously said it was fine to merge it (ignoring Piotr's new information for
now). Why do you think I didn't do it right away?
What would you say if Matt had merged it, even when Piotr and you had concerns?
Who actually can merge things into the codebase?
Although my proposal of "merge if no harm, discuss if necessary" may seem
naive, let's work on it. I am aiming at avoiding codebase ownership and
contributor retention, which is as just as serious as product mindset and
security.
Hope that clarifies my intention.
Cheers
Christian
