[ 
https://issues.apache.org/jira/browse/LUCENE-2655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916979#action_12916979
 ] 

Jason Rutherglen commented on LUCENE-2655:
------------------------------------------

{quote}when IW.deleteDocs(Term/Query) is called, we must go to each DWPT, grab 
its current docID, and enroll Term/Query -> docID into that DWPT's pending 
deletes map.{quote}

Ok, that's the change you're referring to. In the current RT revision, the 
deletes are held in one map in DW, guess we need to change that. However if we 
do, why do we need to keep the seq id or docid as the value in the map? When 
the delete arrives into the DWPT, we know that any buffered docs with that 
term/query need to be deleted on flush? (ie, lets *not* worry about the RT 
search use case, yet). ie2, we can simply add the terms/queries to a set, and 
apply them on flush, ala LUCENE-2679?

bq. NRT improvements

We're referring to LUCENE-1516 as NRT and LUCENE-2312 as 'RT'. I'm guessing you 
mean RT? 

> Get deletes working in the realtime branch
> ------------------------------------------
>
>                 Key: LUCENE-2655
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2655
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: Realtime Branch
>            Reporter: Jason Rutherglen
>             Fix For: Realtime Branch
>
>         Attachments: LUCENE-2655.patch
>
>
> Deletes don't work anymore, a patch here will fix this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to