[
https://issues.apache.org/jira/browse/SOLR-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875225#comment-13875225
]
Hoss Man commented on SOLR-5594:
--------------------------------
Anshum: looks pretty good ... a few requests...
* SolrQueryParserBase.newPrefixQuery shouldnt' be removed completely (it's
protected, subclasses might be using it) ... just update it to call the new
method on the FieldType.
* can you add some javadocs to the test classes (particularly the new field
types) with an explanation of what they do and why they are special
* can we change the field names in your test schema (currently "customfield"
and "customfield2") to something more clear what they do (ie: "swap_foo_bar"
and "int_prefix_as_range") so the (expected) wonky behavior is less confusing
when reading the test?
* the tests should be updated to show that using {{\{!prefix\}}} and
{{\{!simple\}}} also works with your custom field types
* ideally we want to show that {{\{!prefix\}}}, {{\{!simple\}}}, and
{{\{!lucene\}}} all produce queries that are _equals()_ when using your custom
field types (take a look at QueryEqualityTest for inspiration)
> Enable using extended field types with prefix queries for non-default encoded
> strings
> -------------------------------------------------------------------------------------
>
> Key: SOLR-5594
> URL: https://issues.apache.org/jira/browse/SOLR-5594
> Project: Solr
> Issue Type: Improvement
> Components: query parsers, Schema and Analysis
> Affects Versions: 4.6
> Reporter: Anshum Gupta
> Assignee: Anshum Gupta
> Priority: Minor
> Attachments: SOLR-5594-branch_4x.patch, SOLR-5594.patch,
> SOLR-5594.patch, SOLR-5594.patch, SOLR-5594.patch
>
>
> Enable users to be able to use prefix query with custom field types with
> non-default encoding/decoding for queries more easily. e.g. having a custom
> field work with base64 encoded query strings.
> Currently, the workaround for it is to have the override at getRewriteMethod
> level. Perhaps having the prefixQuery also use the calling FieldType's
> readableToIndexed method would work better.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
