[
https://issues.apache.org/jira/browse/SOLR-5594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13865215#comment-13865215
]
Anshum Gupta commented on SOLR-5594:
------------------------------------
Thanks for the feedback Hoss!
I've tried to be less invasive this time around and have avoided using
readableToIndexed in the base class. I've also fixed the javadocs.
About using the BinaryTokenStream (extending BinaryField), I may be missing
something as far as the reason is concerned but it's tough to work with
BinaryFields right now. They can not be indexed really and the only way to
index a binary field is through the hack I put it.
I've removed all of that and made this more generic.
I'll also open a separate JIRA to make BinaryFields better and more usable.
Here's what still remains before this can be checked in:
* Fix/change dependent Parser classes e.g. PrefixQParserPlugin and
SimpleQParserPlugin.
* A test that shows that things haven't changed for the existing field types as
far as Prefix Queries are concerned.
Need a couple of hours for that.
> Enable using extended field types with prefix queries for non-default encoded
> strings
> -------------------------------------------------------------------------------------
>
> Key: SOLR-5594
> URL: https://issues.apache.org/jira/browse/SOLR-5594
> Project: Solr
> Issue Type: Improvement
> Components: query parsers, Schema and Analysis
> Affects Versions: 4.6
> Reporter: Anshum Gupta
> Assignee: Anshum Gupta
> Priority: Minor
> Attachments: SOLR-5594-branch_4x.patch, SOLR-5594.patch,
> SOLR-5594.patch
>
>
> Enable users to be able to use prefix query with custom field types with
> non-default encoding/decoding for queries more easily. e.g. having a custom
> field work with base64 encoded query strings.
> Currently, the workaround for it is to have the override at getRewriteMethod
> level. Perhaps having the prefixQuery also use the calling FieldType's
> readableToIndexed method would work better.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
