[
https://issues.apache.org/jira/browse/LUCENE-5414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13880328#comment-13880328
]
Robert Muir commented on LUCENE-5414:
-------------------------------------
+1 to just take ValueSource like this patch, I think it keeps our dependencies
simpler and cleaner.
I also think we could remove the test dep too (in the future or whatever),
because the test only needs to show it consumes valuesource correctly.
> suggest module should not depend on expression module
> -----------------------------------------------------
>
> Key: LUCENE-5414
> URL: https://issues.apache.org/jira/browse/LUCENE-5414
> Project: Lucene - Core
> Issue Type: Wish
> Affects Versions: 4.6, 5.0
> Reporter: Simon Willnauer
> Fix For: 5.0, 4.7
>
> Attachments: LUCENE-5414.patch
>
>
> Currently our suggest module depends on the expression module just because
> the DocumentExpressionDictionary provides some util ctor to pass in an
> expression directly. That is a lot of dependency for little value IMO and
> pulls in lots of JARs. DocumentExpressionDictionary should only take a
> ValueSource instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
