[
https://issues.apache.org/jira/browse/LUCENE-5414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13880555#comment-13880555
]
Steve Rowe commented on LUCENE-5414:
------------------------------------
bq. I am still after all these years not familiar with how we manage the maven
stuff but I guess it somehow figures this out?
LUCENE-5217 recently added an Ant+Ivy->Maven dependencies converter that also
defeats Maven's transitive dependency resolution mechanism by excluding all
dependencies' direct dependencies in the {{<dependencyManagement>}} section of
the grandparent POM.
I ran {{ant get-maven-poms}} before and after the latest patch on this issue
and compared the resulting suggest module's POMs. With the patch, the
following dependencies are no longer present:
{code:xml}
<dependency>
<groupId>org.apache.lucene</groupId>
<artifactId>lucene-expressions</artifactId>
</dependency>
...
<dependency>
<groupId>org.antlr</groupId>
<artifactId>antlr-runtime</artifactId>
</dependency>
<dependency>
<groupId>org.ow2.asm</groupId>
<artifactId>asm</artifactId>
</dependency>
<dependency>
<groupId>org.ow2.asm</groupId>
<artifactId>asm-commons</artifactId>
</dependency>
{code}
Those last three dependencies are direct dependencies of the expressions
module; since the Ant build currently pulls in everything from
{{expressions/lib/}}, the Ant->Maven dependencies converter interprets them as
direct dependencies of the suggest module.
After applying the latest patch, all Lucene/Solr tests pass under Maven.
> suggest module should not depend on expression module
> -----------------------------------------------------
>
> Key: LUCENE-5414
> URL: https://issues.apache.org/jira/browse/LUCENE-5414
> Project: Lucene - Core
> Issue Type: Wish
> Affects Versions: 4.6, 5.0
> Reporter: Simon Willnauer
> Fix For: 5.0, 4.7
>
> Attachments: LUCENE-5414.patch, LUCENE-5414.patch
>
>
> Currently our suggest module depends on the expression module just because
> the DocumentExpressionDictionary provides some util ctor to pass in an
> expression directly. That is a lot of dependency for little value IMO and
> pulls in lots of JARs. DocumentExpressionDictionary should only take a
> ValueSource instead.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
