[
https://issues.apache.org/jira/browse/LUCENE-5445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13902427#comment-13902427
]
ASF GitHub Bot commented on LUCENE-5445:
----------------------------------------
Github user sunbeansoft commented on the pull request:
https://github.com/apache/lucene-solr/pull/32#issuecomment-35158015
发送自HTC手机
----- Reply message -----
发件人： "cpoerschke" <[email protected]>
收件人： "apache/lucene-solr" <[email protected]>
主题： [lucene-solr] factor out abstract base class
EarlySegmentTerminatingCollector (#32)
日期： 周五, 2 月 14 日, 2014 年 22:56
factor out abstract base class EarlySegmentTerminatingCollector and change
existing EarlyTerminatingSortingCollector to inherit from it
For https://issues.apache.org/jira/i#browse/LUCENE-5445 ticket and also
https://issues.apache.org/jira/i#browse/SOLR-5730 ticket (CommonParams.java
comment references EarlySegmentTerminatingCollector class)
You can merge this Pull Request by running
git pull https://github.com/bloomberg/lucene-solr branch_4x-etsc-lucene
Or view, comment on, or merge it at:
https://github.com/apache/lucene-solr/pull/32
Commit Summary
factor out abstract base class EarlySegmentTerminatingCollector and change
existing EarlyTerminatingSortingCollector to inherit from it
File Changes
A
lucene/core/src/java/org/apache/lucene/search/EarlySegmentTerminatingCollector.java
(66)
M
lucene/misc/src/java/org/apache/lucene/index/sorter/EarlyTerminatingSortingCollector.java
(35)
M
lucene/misc/src/test/org/apache/lucene/index/sorter/TestEarlyTermination.java
(2)
Patch Links:
https://github.com/apache/lucene-solr/pull/32.patch
https://github.com/apache/lucene-solr/pull/32.diff
—
Reply to this email directly or view it on GitHub.
> factor out abstract base class EarlySegmentTerminatingCollector and change
> existing EarlyTerminatingSortingCollector to inherit from it
> ---------------------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-5445
> URL: https://issues.apache.org/jira/browse/LUCENE-5445
> Project: Lucene - Core
> Issue Type: Wish
> Reporter: Christine Poerschke
> Priority: Minor
>
> Solr has an {noformat}EarlyTerminatingCollector{noformat} which operates
> across segments, a Lucene abstract base class
> {noformat}EarlySegmentTerminatingCollector{noformat} (or some other name)
> could make the distinction between the two terminating collector varieties
> clearer.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
