[ 
https://issues.apache.org/jira/browse/LUCENE-5445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13901512#comment-13901512
 ] 

ASF GitHub Bot commented on LUCENE-5445:
----------------------------------------

GitHub user cpoerschke opened a pull request:

    https://github.com/apache/lucene-solr/pull/32

    factor out abstract base class EarlySegmentTerminatingCollector

    factor out abstract base class EarlySegmentTerminatingCollector and change 
existing EarlyTerminatingSortingCollector to inherit from it
    
    For https://issues.apache.org/jira/i#browse/LUCENE-5445 ticket and also 
https://issues.apache.org/jira/i#browse/SOLR-5730 ticket (CommonParams.java 
comment references EarlySegmentTerminatingCollector class)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/lucene-solr branch_4x-etsc-lucene

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #32
    
----
commit 1c8e540213c6234b425b08168148866c7c34bd45
Author: Christine Poerschke <[email protected]>
Date:   2014-02-14T13:58:20Z

    factor out abstract base class EarlySegmentTerminatingCollector and change 
existing EarlyTerminatingSortingCollector to inherit from it

----


> factor out abstract base class EarlySegmentTerminatingCollector and change 
> existing EarlyTerminatingSortingCollector to inherit from it
> ---------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-5445
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5445
>             Project: Lucene - Core
>          Issue Type: Wish
>            Reporter: Christine Poerschke
>            Priority: Minor
>
> Solr has an {noformat}EarlyTerminatingCollector{noformat} which operates 
> across segments, a Lucene abstract base class 
> {noformat}EarlySegmentTerminatingCollector{noformat} (or some other name) 
> could make the distinction between the two terminating collector varieties 
> clearer.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to