[ 
https://issues.apache.org/jira/browse/SOLR-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910397#comment-13910397
 ] 

Elran Dvir commented on SOLR-2894:
----------------------------------

Brett (and your team), thank you very much for your hard work. We've been 
having a lot of performance issues with using the previous version patch (which 
we love), and initial testing shows they are now resolved.

We did also notice a few issues:

1) f.field.facet.limit=-1 is not being respected (as reported by me on 
20/May/13 10:27)

2) pivot queries are returning String instead of Object (as reported by me on 
25/Aug/13 07:38) except for boolean fields. 
I know the reason is there was a problem with datetime fields. I changed it 
back to toObject and I can't reproduce any issues running unit test locally via 
maven.
I'd be glad to help fix this problem, if anyone can create a simple test case 
that fails ?

3) The following query throws an exception:

q=*:*&rows=0&f.fieldA.facet.sort=index&f.fieldA.facet.limit=-1&f.fieldA.facet.missing=true&f.fieldA.facet.mincount=1&f.fieldB.facet.sort=index&f.fieldB.facet.limit=-1&f.fieldB.facet.missing=true&f.fieldB.facet.mincount=1&facet=true&facet.pivot=fieldA,fieldB&shards=127.0.0.1:8983/solr/shardA,127.0.0.1:8983/solr/shardB

java.lang.IllegalArgumentException: fromIndex(0) > toIndex(-1) at 
java.util.ArrayList.subListRangeCheck(ArrayList.java:975) at 
java.util.ArrayList.subList(ArrayList.java:965) at 
org.apache.solr.handler.component.PivotFacetField.refineNextLevelOfFacets(PivotFacetField.java:276)
 at 
org.apache.solr.handler.component.PivotFacetField.queuePivotRefinementRequests(PivotFacetField.java:231)
 at 
org.apache.solr.handler.component.PivotFacet.queuePivotRefinementRequests(PivotFacet.java:86)
 at 
org.apache.solr.handler.component.FacetComponent.countFacets(FacetComponent.java:565)
 at 
org.apache.solr.handler.component.FacetComponent.handleResponses(FacetComponent.java:413)
 at 
org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:311)
 at 
org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:135)
 at org.apache.solr.core.SolrCore.execute(SolrCore.java:1904) at 
org.apache.solr.servlet.SolrDispatchFilter.execute(SolrDispatchFilter.java:659) 
at 
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:362)
 at 
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:158)
 at 
org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1474)
 at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:499) 
at 
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137) 
at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557) 
at 
org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)
 at 
org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)
 at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:428) 
at 
org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)
 at 
org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)
 at 
org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135) 
at 
org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:255)
 at 
org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:154)
 at 
org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116) 
at org.eclipse.jetty.server.Server.handle(Server.java:370) at 
org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:489)
 at 
org.eclipse.jetty.server.BlockingHttpConnection.handleRequest(BlockingHttpConnection.java:53)
 at 
org.eclipse.jetty.server.AbstractHttpConnection.headerComplete(AbstractHttpConnection.java:949)
 at 
org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.headerComplete(AbstractHttpConnection.java:1011)
 at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:644) at 
org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:235) at 
org.eclipse.jetty.server.BlockingHttpConnection.handle(BlockingHttpConnection.java:72)
 at 
org.eclipse.jetty.server.bio.SocketConnector$ConnectorEndPoint.run(SocketConnector.java:264)
 at 
org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608)
 at 
org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:543) 
at java.lang.Thread.run(Thread.java:804)

Thank you again for this great patch!





> Implement distributed pivot faceting
> ------------------------------------
>
>                 Key: SOLR-2894
>                 URL: https://issues.apache.org/jira/browse/SOLR-2894
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Erik Hatcher
>             Fix For: 4.7
>
>         Attachments: SOLR-2894-reworked.patch, SOLR-2894.patch, 
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, 
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, 
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, 
> SOLR-2894.patch, SOLR-2894.patch
>
>
> Following up on SOLR-792, pivot faceting currently only supports 
> undistributed mode.  Distributed pivot faceting needs to be implemented.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to