[
https://issues.apache.org/jira/browse/SOLR-2894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920417#comment-13920417
]
Brett Lucey commented on SOLR-2894:
-----------------------------------
We have been trying to finish up the distributed pivot facet patch to submit it
for committing, but we've run into one issue raised in the JIRA issue for the
patch.
Distributed field facets appear to convert all values to strings, and refine on
those strings when needed. The solrj test cases around the distributed field
facets also expect all values to be represented as strings. Please correct me
if I'm wrong.
The most recent revision of the patch for SOLR-2894 converts all values to
strings as well, except in the case of booleans. If we don't have this
exception, the solrj test case of distributed pivot facets will fail because
there is an assert verifying that the value returned is Boolean.TRUE rather
than "true". If we do not convert object values to strings, we are unable to
refine on date time's because the format will be incorrect and the date time
class is unable to convert it back.
Our feeling is that this assert is incorrect and that it should be looking for
the string true. Changing this test case would allow us to bring the behavior
of distributed pivot facets into consistency with the behavior of distributed
field facets. We didn't want to just go ahead and make that change because it
would change the behavior of solrj.
It appears our options are:
1. Convert all values to strings. Modify the solrj test case to expect this.
We feel this makes things consistent and is the ideal option.
2. Convert all values exception booleans to strings.
3. Leave all values except datettimes as is.
We are just looking for some input from the community prior to adding this
change to our patch.
> Implement distributed pivot faceting
> ------------------------------------
>
> Key: SOLR-2894
> URL: https://issues.apache.org/jira/browse/SOLR-2894
> Project: Solr
> Issue Type: Improvement
> Reporter: Erik Hatcher
> Fix For: 4.7
>
> Attachments: SOLR-2894-reworked.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch,
> SOLR-2894.patch, SOLR-2894.patch, SOLR-2894.patch
>
>
> Following up on SOLR-792, pivot faceting currently only supports
> undistributed mode. Distributed pivot faceting needs to be implemented.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
