[
https://issues.apache.org/jira/browse/SOLR-5771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13910847#comment-13910847
]
Mark Miller commented on SOLR-5771:
-----------------------------------
Thanks!
Don't really know the annotations life cycle, so the static was all I knew of
to get ahead of beforeClass. It was ugly (the other guy working on SSL recoiled
as well, but you had to disable before beforeClass). As Robert pointed out
though, there is a problem with this and inheritance.
An annotation that can jump in before beforeClass is much nicer and actually
works properly.
> Add SuppressSSL instead of static boolean in SolrTestCaseJ4
> -----------------------------------------------------------
>
> Key: SOLR-5771
> URL: https://issues.apache.org/jira/browse/SOLR-5771
> Project: Solr
> Issue Type: Test
> Components: Tests
> Reporter: Robert Muir
> Attachments: SOLR-5771.patch
>
>
> Currently, as of 4.7, solr test-framework classes can no longer be used by
> downstream projects, because ssl configuration will fail (and it expects this
> stuff from outside the source code tree in example/ etc, which makes it
> impossible).
> There is a boolean to disable SSL, but it cannot work correctly unless you
> set it in a static initializer (to "beat" the SolrTestCaseJ4.beforeClass to
> the punch). Then the problem is afterClass turns it off, so if you have e.g.
> a base class run by 2 tests in the same jvm, boom.
> An alternative way, so people can use test-framework again, is to just have
> an annotation to do this. Thats how e.g. codecs and so on are disabled in
> lucene.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
