[
https://issues.apache.org/jira/browse/SOLR-5771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13911551#comment-13911551
]
Robert Muir commented on SOLR-5771:
-----------------------------------
{quote}
Is it expected that downstream projects should add in the annotation? As you
noted, ssl configuration will fail because it expects stuff from example/ – we
can't test for this and automatically disable?
{quote}
No. This issue is just to replace the static boolean with an annotation. For
me, thats enough, as it makes the solr code itself cleaner, and it also gives
downstream projects back the same capabilities they had in 4.6 and before.
Yes its true, in practice you will have to do this right now if you want to use
these test classes all in an outside project. As far as autodetection, I don't
think tests should automatically 'pass' when misconfigured: that makes them
useless. I also think things like example keystores are useless too, and that
the only proper fix is to move that "test keystore" to a src/resources in the
test-framework.jar. But personally I don't want to tackle all this (please open
an issue if you do!)
> Add SuppressSSL instead of static boolean in SolrTestCaseJ4
> -----------------------------------------------------------
>
> Key: SOLR-5771
> URL: https://issues.apache.org/jira/browse/SOLR-5771
> Project: Solr
> Issue Type: Test
> Components: Tests
> Reporter: Robert Muir
> Attachments: SOLR-5771.patch
>
>
> Currently, as of 4.7, solr test-framework classes can no longer be used by
> downstream projects, because ssl configuration will fail (and it expects this
> stuff from outside the source code tree in example/ etc, which makes it
> impossible).
> There is a boolean to disable SSL, but it cannot work correctly unless you
> set it in a static initializer (to "beat" the SolrTestCaseJ4.beforeClass to
> the punch). Then the problem is afterClass turns it off, so if you have e.g.
> a base class run by 2 tests in the same jvm, boom.
> An alternative way, so people can use test-framework again, is to just have
> an annotation to do this. Thats how e.g. codecs and so on are disabled in
> lucene.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
