[ 
https://issues.apache.org/jira/browse/SOLR-5265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13922452#comment-13922452
 ] 

Noble Paul commented on SOLR-5265:
----------------------------------

don't use toString() to compare test actual values

don't use FileInputstream, Use 
getClass().getResourceAsStream("/solrj/updateReq_4_5.bin") as given in 
TestUpdateRequestCodec

add the rest of the types

We also need a forward compatibility tests

> Add backward compatibility tests to JavaBinCodec's format.
> ----------------------------------------------------------
>
>                 Key: SOLR-5265
>                 URL: https://issues.apache.org/jira/browse/SOLR-5265
>             Project: Solr
>          Issue Type: Test
>            Reporter: Adrien Grand
>            Priority: Blocker
>             Fix For: 4.7
>
>         Attachments: SOLR-5265.patch
>
>
> Since Solr guarantees backward compatibility of JavaBinCodec's format between 
> releases, we should have tests for it.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to