[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954720#comment-13954720
]
Mark Miller commented on SOLR-5914:
-----------------------------------
bq. I looked at the current state of the branch, Mark, and I strongly disagree
with having this in TestUtil: boolean ensureCleanedUp
I don't really care about that - I left the tension between your clean up
method and Solr's because yours is not good enough for our needs yet and Solr's
is not making you happy. Like I said, that's the stuff that is left to clean
up. I had to put that in now, because the spellcheck tests need to run and pass.
bq. My suggestion is
That sounds fine to me - I would prefer first class test framework support for
this rather than having it just be a Solr thing. Though come to think of it,
yes, I'd prefer test was in the folder name rather than just the classname.
bq. I also don't quite understand why you insist on things like this:
I don't insist - I think that was just already there.
bq. it isn't true.
My comment wasn't meant to indicate order of deletion. What it meant is that
since we prevent the folder from being cleaned up via TestUtil, I still left
that recursive delete so that any files that can be deleted still are.
Like I said, this is the piece that is left to cleanup - and it's what I
thought you intended from the begging. This is what I meant when I said Dawid
was working on first class test framework support and I was just doing the fix
that made sense in the current world.
Anyway, we always seem to have been on the same page but it seems you want to
insist that we are not. Strange to me, but we will get there. No hurry anymore
at least.
> Almost all Solr tests no longer cleanup their temp dirs on Windows
> ------------------------------------------------------------------
>
> Key: SOLR-5914
> URL: https://issues.apache.org/jira/browse/SOLR-5914
> Project: Solr
> Issue Type: Bug
> Components: Tests
> Affects Versions: 4.8
> Reporter: Uwe Schindler
> Assignee: Dawid Weiss
> Priority: Critical
> Fix For: 4.8
>
> Attachments: SOLR-5914 .patch, SOLR-5914 .patch,
> branch4x-jenkins.png, build-plugin.jpg, trunk-jenkins.png
>
>
> Recently the Windows Jenkins Build server has the problem of all-the time
> running out of disk space. This machine runs 2 workspaces (4.x and trunk) and
> has initially 8 Gigabytes of free SSD disk space.
> Because of the recently all-the time failing tests, the test framework does
> not forcefully clean up the "J0" working folders after running tests. This
> leads to the fact, that the workspace is filled with tons of Solr Home dirs.
> I tried this on my local machine:
> - run ant test
> - go to build/.../test/J0 and watch folders appearing: Almost every test no
> longer cleans up after shutting down, leaving a million of files there. This
> is approx 3 to 4 Gigabytes!!!
> In Lucene the folders are correctly removed. This has happened recently, so i
> think we have some code like ([~erickerickson] !!!):
> {{new Properties().load(new FileInputStream(...))}} that does not close the
> files. Because of this, the test's afterClass cannot clean up folders
> anymore. If you look in the test log, you see messages like "{{!!!! WARNING:
> best effort to remove
> C:\Users\JenkinsSlave\workspace\Lucene-Solr-4.x-Windows\solr\build\solr-core\test\J0\.\org.apache.solr.cloud.TestShortCircuitedRequests-1395693845226
> FAILED !!!!!}}" all the time.
> So if anybody committed some changes that might not close files correctly,
> please fix! Otherwise I have to disable testing on windows - and I will no
> longer run solr, tests, too: My local computer also uses gigabytes of temp
> space after running tests!
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
