[
https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13954731#comment-13954731
]
Mark Miller commented on SOLR-5914:
-----------------------------------
Just to make things simpler, take what I'm looking for and insist on from my
comments and look at the branch as a work in progress.
I'll reiterate what I'm looking for:
1. We want a root temp directory for a Solr test. All tmp files created by that
test are under this directory. Directory should be named after test class.
Personally, I'd also prefer Solr and Test where in the name, but thats pretty
low priority compared to the rest. I like tmp folders to be very self
identifiable.
2. As a dev, I want to be able to simply pass a sys prop to get that temp
folder and all it's contents to stick around. Then I can easily explore the
temporary indexes and what not that a test creates.
3. I'd prefer we didn't have TestUtil calls all over the test code. If you want
a temp folder, as you said, you should just have to ask for it - not pass any
params. And getting a tmp dir for a test should be easily discoverable rather
than a random Util class. Also, there should be no need to import.
Those are my main sticking points. The rest is malleable.
> Almost all Solr tests no longer cleanup their temp dirs on Windows
> ------------------------------------------------------------------
>
> Key: SOLR-5914
> URL: https://issues.apache.org/jira/browse/SOLR-5914
> Project: Solr
> Issue Type: Bug
> Components: Tests
> Affects Versions: 4.8
> Reporter: Uwe Schindler
> Assignee: Dawid Weiss
> Priority: Critical
> Fix For: 4.8
>
> Attachments: SOLR-5914 .patch, SOLR-5914 .patch,
> branch4x-jenkins.png, build-plugin.jpg, trunk-jenkins.png
>
>
> Recently the Windows Jenkins Build server has the problem of all-the time
> running out of disk space. This machine runs 2 workspaces (4.x and trunk) and
> has initially 8 Gigabytes of free SSD disk space.
> Because of the recently all-the time failing tests, the test framework does
> not forcefully clean up the "J0" working folders after running tests. This
> leads to the fact, that the workspace is filled with tons of Solr Home dirs.
> I tried this on my local machine:
> - run ant test
> - go to build/.../test/J0 and watch folders appearing: Almost every test no
> longer cleans up after shutting down, leaving a million of files there. This
> is approx 3 to 4 Gigabytes!!!
> In Lucene the folders are correctly removed. This has happened recently, so i
> think we have some code like ([~erickerickson] !!!):
> {{new Properties().load(new FileInputStream(...))}} that does not close the
> files. Because of this, the test's afterClass cannot clean up folders
> anymore. If you look in the test log, you see messages like "{{!!!! WARNING:
> best effort to remove
> C:\Users\JenkinsSlave\workspace\Lucene-Solr-4.x-Windows\solr\build\solr-core\test\J0\.\org.apache.solr.cloud.TestShortCircuitedRequests-1395693845226
> FAILED !!!!!}}" all the time.
> So if anybody committed some changes that might not close files correctly,
> please fix! Otherwise I have to disable testing on windows - and I will no
> longer run solr, tests, too: My local computer also uses gigabytes of temp
> space after running tests!
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
