[ 
https://issues.apache.org/jira/browse/SOLR-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955186#comment-13955186
 ] 

Shalin Shekhar Mangar edited comment on SOLR-5473 at 3/31/14 1:55 PM:
----------------------------------------------------------------------

All solr core tests pass with this patch. After discussing offline with Noble, 
I introduced a new method ClusterState.getCachedReplica which is exactly like 
getReplica except that it will fetch information available in locally cached 
data and never hit ZK. The older getReplica and this new getCachedReplica 
method are used only by SolrLogLayout and SolrLogFormatter classes so these 
should never hit ZK anyway.

However, there is a SolrJ test failure in CloudSolrServerTest on asserts added 
by SOLR-5715

{code}
  [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=CloudSolrServerTest 
-Dtests.method=testDistribSearch -Dtests.seed=5FAC2B1757C387B3 
-Dtests.slow=true -Dtests.locale=sv_SE -Dtests.timezone=Pacific/Samoa 
-Dtests.file.encoding=US-ASCII
   [junit4] FAILURE 22.1s J1 | CloudSolrServerTest.testDistribSearch <<<
   [junit4]    > Throwable #1: java.lang.AssertionError: Unexpected number of 
requests to expected URLs expected:<6> but was:<0>
   [junit4]    >        at 
__randomizedtesting.SeedInfo.seed([5FAC2B1757C387B3:DE4AA50F209CE78F]:0)
   [junit4]    >        at 
org.apache.solr.client.solrj.impl.CloudSolrServerTest.doTest(CloudSolrServerTest.java:300)
   [junit4]    >        at 
org.apache.solr.BaseDistributedSearchTestCase.testDistribSearch(BaseDistributedSearchTestCase.java:867)
   [junit4]    >        at java.lang.Thread.run(Thread.java:744)
   [junit4]   2> 26918 T10 oas.SolrTestCaseJ4.deleteCore ###deleteCore
{code}


was (Author: shalinmangar):
All solr core tests pass with this patch. However, there is a SolrJ test 
failure in CloudSolrServerTest on asserts added by SOLR-5715

{code}
  [junit4]   2> NOTE: reproduce with: ant test  -Dtestcase=CloudSolrServerTest 
-Dtests.method=testDistribSearch -Dtests.seed=5FAC2B1757C387B3 
-Dtests.slow=true -Dtests.locale=sv_SE -Dtests.timezone=Pacific/Samoa 
-Dtests.file.encoding=US-ASCII
   [junit4] FAILURE 22.1s J1 | CloudSolrServerTest.testDistribSearch <<<
   [junit4]    > Throwable #1: java.lang.AssertionError: Unexpected number of 
requests to expected URLs expected:<6> but was:<0>
   [junit4]    >        at 
__randomizedtesting.SeedInfo.seed([5FAC2B1757C387B3:DE4AA50F209CE78F]:0)
   [junit4]    >        at 
org.apache.solr.client.solrj.impl.CloudSolrServerTest.doTest(CloudSolrServerTest.java:300)
   [junit4]    >        at 
org.apache.solr.BaseDistributedSearchTestCase.testDistribSearch(BaseDistributedSearchTestCase.java:867)
   [junit4]    >        at java.lang.Thread.run(Thread.java:744)
   [junit4]   2> 26918 T10 oas.SolrTestCaseJ4.deleteCore ###deleteCore
{code}

> Make one state.json per collection
> ----------------------------------
>
>                 Key: SOLR-5473
>                 URL: https://issues.apache.org/jira/browse/SOLR-5473
>             Project: Solr
>          Issue Type: Sub-task
>          Components: SolrCloud
>            Reporter: Noble Paul
>            Assignee: Noble Paul
>         Attachments: SOLR-5473-74.patch, SOLR-5473-74.patch, 
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch, 
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch, 
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473-74.patch, 
> SOLR-5473-74.patch, SOLR-5473-74.patch, SOLR-5473.patch, SOLR-5473.patch, 
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, 
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, 
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, 
> SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, SOLR-5473.patch, 
> ec2-23-20-119-52_solr.log, ec2-50-16-38-73_solr.log
>
>
> As defined in the parent issue, store the states of each collection under 
> /collections/collectionname/state.json node



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to