[ 
https://issues.apache.org/jira/browse/LUCENE-5670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997744#comment-13997744
 ] 

Christian Ziech commented on LUCENE-5670:
-----------------------------------------

Oh right! I only checked the 4.7 branch and there the DataInput didn't have the 
skipBytes() method yet. But now I saw that both trunk and the 4.8 branch have 
the skipBytes(long) already. So yes of course in that case we can drop it from 
the patch. If we can get consensus that the rest of the patch is worth doing I 
could implement it against 4.8 and attach it here.

> org.apache.lucene.util.fst.FST should skip over outputs it is not interested 
> in
> -------------------------------------------------------------------------------
>
>                 Key: LUCENE-5670
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5670
>             Project: Lucene - Core
>          Issue Type: Improvement
>    Affects Versions: 4.7
>            Reporter: Christian Ziech
>            Assignee: Michael McCandless
>            Priority: Minor
>         Attachments: LUCENE-5670.patch
>
>
> Currently the FST uses the read(DataInput) method from the Outputs class to 
> skip over outputs it actually is not interested in. For most use cases this 
> just creates some additional objects that are immediately destroyed again.
> When traversing an FST with non-trivial data however this can easily add up 
> to several excess objects that nobody actually ever read.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to