[
https://issues.apache.org/jira/browse/LUCENE-5670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997653#comment-13997653
]
Michael McCandless commented on LUCENE-5670:
--------------------------------------------
Sorry, I wasn't talking about the subclasses of DataInput, I was talking about
DataInput.java itself: it already has a skipBytes(long) defined but your patch
adds a skipBytes(int)?
bq. e.g. IndexInput could easily implement the skip method as a comination of
seek and getFilePointer
That's right! Seems silly not to. Let's add it here?
> org.apache.lucene.util.fst.FST should skip over outputs it is not interested
> in
> -------------------------------------------------------------------------------
>
> Key: LUCENE-5670
> URL: https://issues.apache.org/jira/browse/LUCENE-5670
> Project: Lucene - Core
> Issue Type: Improvement
> Affects Versions: 4.7
> Reporter: Christian Ziech
> Assignee: Michael McCandless
> Priority: Minor
> Attachments: LUCENE-5670.patch
>
>
> Currently the FST uses the read(DataInput) method from the Outputs class to
> skip over outputs it actually is not interested in. For most use cases this
> just creates some additional objects that are immediately destroyed again.
> When traversing an FST with non-trivial data however this can easily add up
> to several excess objects that nobody actually ever read.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
