[ 
https://issues.apache.org/jira/browse/LUCENE-5680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14001296#comment-14001296
 ] 

Shai Erera commented on LUCENE-5680:
------------------------------------

bq. I think whats wrong here is that these methods on indexwriter need to use 
Field api or something instead

I thought about it at some point, but I was worried it might suggest that you 
can pass whatever Field, even if the method is called updateDocValues(). If we 
have a DocValuesField base class for all DV field types, that might be better. 
Of course, even if we go w/ a {{Field...}}, we can document that only NDV and 
BDV fields are supported, and throw appropriate exception otherwise.

I wanted to avoid having must-read-the-jdocs API, and {{DocValuesUpdate}} is 
the that _or something instead_ that you mentioned. Note that it's *NOT* 
{{DocValuesFieldUpdate}} which is a heavier class, it's only 
{{DocValuesUpdate}}, which record only the term, field and value. What do you 
think?

> Allow updating multiple DocValues fields atomically
> ---------------------------------------------------
>
>                 Key: LUCENE-5680
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5680
>             Project: Lucene - Core
>          Issue Type: New Feature
>          Components: core/index
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>         Attachments: LUCENE-5680.patch, LUCENE-5680.patch
>
>
> This has come up on the list (http://markmail.org/message/2wmpvksuwc5t57pg) 
> -- it would be good if we can allow updating several doc-values fields, 
> atomically. It will also improve/simplify our tests, where today we index two 
> fields, e.g. the field itself and a control field. In some multi-threaded 
> tests, since we cannot be sure which updates came through first, we limit the 
> test such that each thread updates a different set of fields, otherwise they 
> will collide and it will be hard to verify the index in the end.
> I was working on a patch and it looks pretty simple to do, will post a patch 
> shortly.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to