[
https://issues.apache.org/jira/browse/LUCENE-5837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14067689#comment-14067689
]
Uwe Schindler commented on LUCENE-5837:
---------------------------------------
bq. What happens in case "missingValue==null" (which was possible in the old
API)? I am not 100% sure if the current code does the right thing - but if
tests pass I am fine.
Your code does the right thing. You set the long missingValue to 0L and the
specialization NumericDocValuesInstance returns missingValue - which is exactly
the same as if the missingValue was null in old code (the if check then
returned the original value, which was also 0).
One thing: I would remove the variable assignment in the compareXxx methods and
make them one-liners.
> Only check docsWithField when necessary in numeric comparators
> --------------------------------------------------------------
>
> Key: LUCENE-5837
> URL: https://issues.apache.org/jira/browse/LUCENE-5837
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Fix For: 5.0, 4.10
>
> Attachments: LUCENE-5837.patch, LUCENE-5837.patch
>
>
> Our numeric comparators have branches to deal with missing values. However
> there are some cases when checking docs that have a field is not useful:
> - if all docs have a value
> - if no docs have a value
> - if the missing value is 0
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
