[ 
https://issues.apache.org/jira/browse/SOLR-6260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14069233#comment-14069233
 ] 

Mark Miller commented on SOLR-6260:
-----------------------------------

bq. That will also lessen the pain next time someone comes up with a better 
name 

That's an important part of this issue too. We should clearly document that 
this is an expert and internal class. We need to own this, and right now it's 
in a grey area. What better time to clear up that it's internal and not user 
supported and rename it all in one. Take it out of config, document at as 
expert/internal.

Unless someone has a burning desire to call it NewUpdateHandler3 in a couple 
years, I think a new name will stick for some time. Anytime you name a class 
Foo2, I think you can expect someone is going to want to "fix" it later. Call 
it Foo or Bar and you will get less name change demand.

> Rename DirectUpdateHandler2
> ---------------------------
>
>                 Key: SOLR-6260
>                 URL: https://issues.apache.org/jira/browse/SOLR-6260
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 5.0
>            Reporter: Tomás Fernández Löbbe
>            Assignee: Mark Miller
>            Priority: Minor
>         Attachments: SOLR-6260.patch, SOLR-6260.patch
>
>
> "DirectUpdateHandler" was removed, I think in Solr 4. DirectUpdateHandler2 
> should be renamed, at least remove that "2". I don't know really what 
> "direct" means here. Maybe it could be renamed to "DefaultUpdateHandler", or 
> "UpdateHandlerDefaultImpl", or other good suggestions



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to