[
https://issues.apache.org/jira/browse/SOLR-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083970#comment-14083970
]
Shai Erera commented on SOLR-6315:
----------------------------------
First, this class is entirely bogus the way I see it. Its javadocs are
completely unrelated to the class itself. SimpleOrderedMap ===== NamedList ...
well, at least if you ignore JSONResponseWriter hack around it. This issue is
about fixing that -- removing that bogus class and make the rest of the code
use the right thing, which is NamedList.
As for ordering, of NamedList in general, I didn't see places in the code that
rely on ordering between keys. That is if you set the keys "k2" and "k1", that
anywhere some piece of code relies on getting them in that order. The only
ordering I see is between a certain key's _values_.
For Solr users, changing the default json.nl to "map" from "flat" will require
users to review their app on upgrade. But as I noted, since the majority of the
code uses SimpleOrderedMap, and since JSONResponseWriter *always* serializes it
as a "map", totally ignoring json.nl, I doubt if that's a real backwards break.
I'd welcome any solution that will allow us to get rid of that redundant class
and keep Solr act as it does today ...
> Remove SimpleOrderedMap
> -----------------------
>
> Key: SOLR-6315
> URL: https://issues.apache.org/jira/browse/SOLR-6315
> Project: Solr
> Issue Type: Improvement
> Components: clients - java
> Reporter: Shai Erera
> Assignee: Shai Erera
> Attachments: SOLR-6315.patch
>
>
> As I described on SOLR-912, SimpleOrderedMap is redundant and generally
> useless class, with confusing jdocs. We should remove it. I'll attach a patch
> shortly.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
