[
https://issues.apache.org/jira/browse/LUCENE-5850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14086061#comment-14086061
]
Uwe Schindler commented on LUCENE-5850:
---------------------------------------
How should we proceed with this.
I would suggest to commit this for now, so we can then work on extending
Version.java? This patch mainly restores Lucene 4.x and trunk into a
releaseable state. The current one, would not work for minor version releases,
because the tests would prevent this from working (the current code in
trunk/4.x does not allow minor versions in LUCENE_MAIN_VERSION).
So should I commit this to 4.x and trunk
BTW: Lucene 4.9.1 would be releaseable, as the tests are enforcing
LUCENE_MAIN_VERSION to be "4.9", not "4.9.1", so the problem Simon mentioned is
not there. The additional smoketester check was not committed to 4.9 branch, so
this would not break 4.9.1 release.
> Constants#LUCENE_MAIN_VERSION can have broken values
> -----------------------------------------------------
>
> Key: LUCENE-5850
> URL: https://issues.apache.org/jira/browse/LUCENE-5850
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/build
> Affects Versions: 4.3.1, 4.5.1
> Reporter: Simon Willnauer
> Fix For: 5.0, 4.10
>
> Attachments: LUCENE-5850.patch, LUCENE-5850.patch, LUCENE-5850.patch,
> LUCENE-5850.patch, LUCENE-5850.patch, LUCENE-5850.patch,
> LUCENE-5850_bomb.patch, LUCENE-5850_smoketester.patch
>
>
> Constants#LUCENE_MAIN_VERSION is set to the Lucene Main version and should
> not contain minor versions. Well this is at least what I thought and to my
> knowledge what the comments say too. Yet in for instance 4.3.1 and 4.5.1 we
> broke this such that the version from SegmentsInfo can not be parsed with
> Version#parseLeniently. IMO we should really add an assertion that this
> constant doesn't throw an error and / or make the smoketester catch this. to
> me this is actually a index BWC break. Note that 4.8.1 doesn't have this
> problem...
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
