[
https://issues.apache.org/jira/browse/LUCENE-5889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107497#comment-14107497
]
Hoss Man edited comment on LUCENE-5889 at 8/22/14 9:37 PM:
-----------------------------------------------------------
bq. But looking into the Solr factories and suggest component, there seems to
be no way to close a suggester (close() is never callled).
Huh?
Awe, damn it ... on trunk Suggester registers a CloseHook for the Lookup, but
apparently that never got backported to 4x.
So it looks like this is in fact a bug in Solr's Suggester class and we've just
ben (un)lucky that are tests never triggered it, but the new logic added here
(aparently) shifts when the write locks are held, so w/o the CloseHook the
tests are failing.
I'll open a new Jira: SOLR-5322
(Thanks Areek!)
was (Author: hossman):
bq. But looking into the Solr factories and suggest component, there seems to
be no way to close a suggester (close() is never callled).
Huh?
Awe, damn it ... on trunk Suggester registers a CloseHook for the Lookup, but
apparently that never got backported to 4x.
So it looks like this is in fact a bug in Solr's Suggester class and we've just
ben (un)lucky that are tests never triggered it, but the new logic added here
(aparently) shifts when the write locks are held, so w/o the CloseHook the
tests are failing.
I'll open a new Jira
> AnalyzingInfixSuggester should expose commit()
> ----------------------------------------------
>
> Key: LUCENE-5889
> URL: https://issues.apache.org/jira/browse/LUCENE-5889
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spellchecker
> Reporter: Mike Sokolov
> Fix For: 5.0, 4.11
>
> Attachments: LUCENE-5889.patch, LUCENE-5889.patch
>
>
> There is no way short of close() for a user of AnalyzingInfixSuggester to
> cause it to commit() its underlying index: only refresh() is provided. But
> callers might want to ensure the index is flushed to disk without closing.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
