[
https://issues.apache.org/jira/browse/LUCENE-5863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128807#comment-14128807
]
Robert Muir commented on LUCENE-5863:
-------------------------------------
{quote}
I think to be safe in TestBackwradsCompatibility(3.x) we should also do a check
on the reported SegmentInfos version! So if we backwardstest a 4.0 index, we
should check the version number with the version constant.
This would go inline with renaming all indexes to have a better naming scheme
(according to LUCENE_x_x_x constants). We could then do something like
backwardsReader.getSegmentInfos().getVersion() == LUCENE_x_x_x.
We can do this in a separate issue, I would help with the renaming task (please
Robert, don't complain about this comment again), I just posted it for
completeness to collect ideas. The smoker stuff also does not really belong
here.
{quote}
I trust you understand that in many of these releases this value is missing
(3.0.x) or wrong (bugfix releases).
As far as complaining about renaming things, I think i have the right to push
back there. I'm the one generating all these horrible indexes. In many previous
versions, the generation code does not even work, and i have to fix bugs in it.
Its a real pain. So Its important to not make my life more difficult than it
already is here.
On the other hand mike's checker actually helps me as I can see if i missed
something.
> Generate backwards compatibility indexes for all 4.x releases
> -------------------------------------------------------------
>
> Key: LUCENE-5863
> URL: https://issues.apache.org/jira/browse/LUCENE-5863
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Attachments: testTheBWCTester.py
>
>
> Currently the versioning here is a total mess, and its inconsistent across
> bugfix releases.
> We should just generate back compat indexes for every release: regardless of
> whether the index format changed, even for bugfix releases. This ensures at
> least we try to test that the back compat is working.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
